From: "taylor, david" <david.taylor@emc.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PING] RE: [PATCH v2] Support structure offsets that are 512K bytes or larger.
Date: Tue, 21 Jun 2016 12:08:00 -0000 [thread overview]
Message-ID: <63F1AEE13FAE864586D589C671A6E18B0636DA@MX203CL03.corp.emc.com> (raw)
In-Reply-To: <CAH=s-POFf_m_SZwz-WTMTuAxgWJcAwQT8sVw075qshqAhraKaQ@mail.gmail.com>
> -----Original Message-----
> From: Yao Qi [mailto:qiyaoltc@gmail.com]
> Sent: Tuesday, June 21, 2016 3:56 AM
> To: taylor, david
> Cc: gdb-patches@sourceware.org
> Subject: Re: [PING] RE: [PATCH v2] Support structure offsets that are 512K
> bytes or larger.
>
> On Mon, Jun 20, 2016 at 2:17 PM, taylor, david <david.taylor@emc.com>
> wrote:
> > Ping. Previous ping failed to add '[PING]' to subject line.
>
> I reviewed the patch https://sourceware.org/ml/gdb-patches/2016-
> 06/msg00194.html
> Please fix some nits in my review, and your patch can go in.
>
> --
> Yao (齐尧)
HI Yao,
Thanks. Your response on Friday never arrived in my mailbox. A fair bit of gdb-patches
never makes it to my mailbox and I somehow missed your response when I checked
the mailing list archives before sending the ping. Sorry.
I think that some messages get filtered based on size, but there seem to be other
criteria as well. EMC's IT department is generally unhelpful.
The nits you point out are all easy to deal with. One issue. You say, in part:
> I rebuild native i686-w64-mingw32 gdb with your patch, the build is
> OK. The patch is good to me, some nits below. You can push it in if no
> other comments in 3~4 days.
I cannot push it as I do not have 'write after approval' status.
Should I port an updated version addressing the nits? Or ...?
prev parent reply other threads:[~2016-06-21 12:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 13:18 taylor, david
2016-06-21 7:56 ` Yao Qi
2016-06-21 12:08 ` taylor, david [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63F1AEE13FAE864586D589C671A6E18B0636DA@MX203CL03.corp.emc.com \
--to=david.taylor@emc.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox