From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ARa0EulbB2oCwj0AWB0awg (envelope-from ) for ; Fri, 15 May 2026 13:46:17 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IvKayJLl; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 48BDE1E0B1; Fri, 15 May 2026 13:46:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2C4F61E067 for ; Fri, 15 May 2026 13:46:16 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A80E340A24A1 for ; Fri, 15 May 2026 17:46:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A80E340A24A1 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IvKayJLl Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id CDA3740A1FBE for ; Fri, 15 May 2026 17:45:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CDA3740A1FBE Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CDA3740A1FBE Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778867132; cv=none; b=OK3feaAooCM6TXd1kEoQGy1F3jpzyWSNYxZP34AwsaBqYwdI+q5Cb8w2r1g7dlEoUzQrmUk6+O5jKb5xZO5C6PZFcks/UTT7MCpgxkVHGY3dGQpCaM94ORDU5pQavu6kvP7PLk7tnE1mMHsVdCp4OmJGJ7E6hLiekcnrxGDjA9U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778867132; c=relaxed/simple; bh=pszD6TJT5JPbIuyrxtpQk2CpH4BS9v31LlU+PJ1RXkc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=NZ8JkBOhkBxr/b8lRReU9sfTPfIznMNhfmqcF05Mz/R/lF7HUJUeMUuBJNHppg7w14rKGhNxpZFezLJ0cR3rMhTGQbfP8sEFfno6mytme89d5YJjogsD2fbWv0uTpRi9v8dPtKRSJL1rmQM8Ij0lkWo2lKZwZJWCGd09N2G2+AQ= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IvKayJLl DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CDA3740A1FBE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778867132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MFxrI4j2JivaZgQyJHEf2bhuWvg5j3fq4OJTo4mg/is=; b=IvKayJLlrUx/suWust7bWTmbGkxyUPiUjw4k6BRa1jDMJUWxGzIITzxS8Fuvs/cei+k3+v 9ayx+HSwcprYxRv+cfA5x8fZAuNmIqe0RkOka+4UL4GyROgFXIKXeebcKC3zn47pmwMScz IBSU/GIsiPJKdEHRaurw7JgpfYl52LU= Received: from mail-dl1-f70.google.com (mail-dl1-f70.google.com [74.125.82.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-Byqv2SmCOCmuM7ofuHJhqQ-1; Fri, 15 May 2026 13:45:31 -0400 X-MC-Unique: Byqv2SmCOCmuM7ofuHJhqQ-1 X-Mimecast-MFC-AGG-ID: Byqv2SmCOCmuM7ofuHJhqQ_1778867130 Received: by mail-dl1-f70.google.com with SMTP id a92af1059eb24-12dba1e866dso7479c88.1 for ; Fri, 15 May 2026 10:45:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778867129; x=1779471929; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MFxrI4j2JivaZgQyJHEf2bhuWvg5j3fq4OJTo4mg/is=; b=LCfDUbcNQ7xWkHWy4RocogaaOmdMqw/Vt+Haf2vxa6+tEbZc9ytvGrLoZf08Dy0nMc dl/MSAfElWrAIfLWmK4ZNq033G0egP9BTxq5nPSgf6WXA+/IjPUbuQK2IW21Bk8N4ykQ Mnsqg4wOys52gNQv44qN6vf4PB2sPubwia1biMl+0Sm4i819JNyVZpLWCA18wJ6jBWeQ c4WDVjq8HWQKrHO6el4mjXl/yA2O3FMVc6FiOBBR2qA41Za+u2YyvnR4DuVLX2VQYCYT wZcTrbXLd/8dzIQJSIIngkg5VcGRTTR39qVwbraUT/cWPXSk7eDfVRZp9FKV93o98zKC IWGQ== X-Gm-Message-State: AOJu0Yytwr6LCkDjPoKcw7F6Jqnw1rRYiQGhkzEWFCezbJpmLMPywB4j NybZ4wnQsOUdpVuFEzoKzFFAtE0sRzwZy7q/G1aSOmkyFHIfA8+z+NAeph6sBD72uZncHnWpm2X 0fZXsXYu2QYhD0lsu/lbeRv3f3u8k4NMUjxV87uG9j73kakN2Jhk4ZNeWAVHxy/G4ew9VIu+WPR as2ImrYVJFH4CQDRZEv4VuGH99Tx1w0Bhl6VfS2keUBPPHMcjV X-Gm-Gg: Acq92OH38cPvqI05esdw0otWKi1TvFigTwHO/KOg65Cvj9Q5iQA++MHnXoNvcx67cd+ QT0yWC+7Etg1FYeaBP3rNvA4r2a7LZFyGHxzy5mpZwrCNJ9+nnBGABVjhI4eTuiSGYCPeX0WkBk MATL9rlqw5S/311Xk91SgK97nLMXgpQSw7BYHAHaY/m9fn+bv0Ti71yT7NAErXZNMZcz7aPXYua hTLu+70nYu93dz9QQZVcK3Ft+JFxq96+IoCIlQRaJlrQ52cuOqv5R8XKhzN7Fkg0xjgNwhYJNDC 4imi6Hevb8dA3u8az1KgLHf/k0uVHBnG4qa2LQfzJkc33tsdqilCmI1BLv6wWbrgBk8o+jmw5wB 1MwycX/3nTvOuX+h2uLLJxTiHhXzriyYvbvBx0D1Kc/+7mXQ+6xNx8g4apfkL1OkXRafP X-Received: by 2002:a05:7022:439b:b0:12d:de3e:86b1 with SMTP id a92af1059eb24-135000aa985mr2201586c88.20.1778867129245; Fri, 15 May 2026 10:45:29 -0700 (PDT) X-Received: by 2002:a05:7022:439b:b0:12d:de3e:86b1 with SMTP id a92af1059eb24-135000aa985mr2201555c88.20.1778867128543; Fri, 15 May 2026 10:45:28 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:993e:2d5d:7adb:2b6:a50e? ([2804:14d:8084:993e:2d5d:7adb:2b6:a50e]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-134cbed531esm10518751c88.8.2026.05.15.10.45.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 May 2026 10:45:28 -0700 (PDT) Message-ID: <639c13cc-b1bc-4a76-a2bb-040cc1d6665b@redhat.com> Date: Fri, 15 May 2026 14:45:24 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/7] refactor the internals of record-full To: gdb-patches@sourceware.org References: <20260515163706.3355686-1-guinevere@redhat.com> From: Guinevere Larsen In-Reply-To: <20260515163706.3355686-1-guinevere@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2goMDpVlhTRYgDH-m0YygluEkBPEwH4RvuQNakiQ66g_1778867130 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Oops, sorry about the noise, apparently some mis-labelled patch files were kept from one iteration to the next and I sent some emails twice. Please ignore all files that act like there are 6 patches in the series On 5/15/26 1:36 PM, Guinevere Larsen wrote: > This series introduces a refactor and modernization to the record-full > history, moving it form a manually managed doubly-linked list into an > std::deque, which can make better use of caching and might make > execution faster. > > The main driving force behind this change is the plan to implement > support for multithreaded inferiors, since each instruction will need to > know the thread that executed it, and it'll be much easier if there is a > more consistent spot to find all this information. > > Changes for v3: Made the former "cleanup" functions into actual > destructors. To do that and avoid double-frees, I made it so > record_full_entry (and the 2 classes under it) can't be copied, only > moved. Also implemented almost all the feedback from Christina on the > changes. > > Guinevere Larsen (7): > gdb/record: Refactor record history > gdb/record: remove record_full_insn_num > gdb/record: c++ify internal structures of record-full.c > gdb/record: make record_full_history more c++-like > gdb/record: extract the PC to record_full_instruction > gdb/record: Define new version of the record-save section > gdb/record: rename record_full_list to record_full_log > > gdb/NEWS | 4 + > gdb/aarch64-tdep.c | 2 - > gdb/amd64-linux-tdep.c | 3 - > gdb/arm-tdep.c | 2 - > gdb/i386-linux-tdep.c | 3 - > gdb/i386-tdep.c | 4 - > gdb/loongarch-tdep.c | 2 - > gdb/moxie-tdep.c | 2 - > gdb/ppc-linux-tdep.c | 3 - > gdb/record-full.c | 1724 +++++++++++++++++++--------------------- > gdb/record-full.h | 1 - > gdb/riscv-tdep.c | 3 - > gdb/rs6000-tdep.c | 4 - > gdb/s390-linux-tdep.c | 3 - > gdb/s390-tdep.c | 2 - > 15 files changed, 827 insertions(+), 935 deletions(-) > > > base-commit: 62cc7210c87a08a9e10955d9a240cfe0c0b5ee13 -- Cheers, Guinevere Larsen It/she