From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60281 invoked by alias); 7 Mar 2019 23:05:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60257 invoked by uid 89); 7 Mar 2019 23:05:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=H*r:sk:client-, noticed, HContent-Transfer-Encoding:8bit, H*UA:Macintosh X-HELO: mx2.freebsd.org Received: from mx2.freebsd.org (HELO mx2.freebsd.org) (8.8.178.116) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Mar 2019 23:05:05 +0000 Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 34A67989D1; Thu, 7 Mar 2019 23:05:03 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 55296776C4; Thu, 7 Mar 2019 23:05:02 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-3.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id CF587110F8; Thu, 7 Mar 2019 23:05:01 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: [PATCH 2/9] Introduce and use language_set To: Tom Tromey , gdb-patches@sourceware.org References: <20190307205709.21919-1-tom@tromey.com> <20190307205709.21919-3-tom@tromey.com> From: John Baldwin Openpgp: preference=signencrypt Message-ID: <6387c828-db23-3e49-fb76-699f5fc9e82b@FreeBSD.org> Date: Thu, 07 Mar 2019 23:05:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190307205709.21919-3-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 55296776C4 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.92 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.92)[-0.917,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US] X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00180.txt.bz2 On 3/7/19 12:57 PM, Tom Tromey wrote: > I noticed that objfile_per_bfd_storage::demangled_hash_languages is a > std::vector, which seemed quite large for something that, > fundamentally, can be represented as a bit-set. This patch > reimplements it as a bit-set. Hmm, did you consider using std::bitset for langauge_set? You'd still have to write your own iterator class, so it wouldn't save much in terms of lines of code. It just seems a bit odd to write a bitset class from scratch? -- John Baldwin