From: Simon Marchi <simark@simark.ca>
To: Eli Zaretskii <eliz@gnu.org>, Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 7/7] Allow setting a parameter to raise gdb.GdbError
Date: Mon, 24 Sep 2018 02:39:00 -0000 [thread overview]
Message-ID: <6385b06c-ec1a-3e6e-6b81-a4c0f4097556@simark.ca> (raw)
In-Reply-To: <83va77i0ko.fsf@gnu.org>
On 2018-09-15 5:15 a.m., Eli Zaretskii wrote:
>> From: Tom Tromey <tom@tromey.com>
>> Cc: Tom Tromey <tom@tromey.com>
>> Date: Sat, 15 Sep 2018 01:24:59 -0600
>>
>> diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
>> index aca6ec858cf..0487a6f3bf3 100644
>> --- a/gdb/doc/python.texi
>> +++ b/gdb/doc/python.texi
>> @@ -3824,6 +3824,30 @@ example, @kbd{set foo off}). The @code{value} attribute has already
>> been populated with the new value and may be used in output. This
>> method must return a string. If the returned string is not empty,
>> @value{GDBN} will present it to the user.
>> +
>> +If this method raises @code{gdb.GdbError} (@pxref{Exception
>
> "raises the 'gdb.GdbError' exception", I presume?
I think that was intentional, I often see it written this way. Here's
an example from the Python doc:
https://docs.python.org/2/library/string.html#string.index
Everything in that series looks reasonable to me, thanks for doing this.
Have you tried to run your tests on Python 3 though? I get some failures
because long doesn't exist there.
Simon
next prev parent reply other threads:[~2018-09-24 2:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-15 7:25 [PATCH 0/7] some small python fixes (one including a doc patch) Tom Tromey
2018-09-15 7:25 ` [PATCH 7/7] Allow setting a parameter to raise gdb.GdbError Tom Tromey
2018-09-15 9:16 ` Eli Zaretskii
2018-09-24 2:39 ` Simon Marchi [this message]
2018-09-24 4:58 ` Tom Tromey
2018-09-24 5:14 ` Tom Tromey
2018-09-24 7:10 ` Eli Zaretskii
2018-09-24 10:24 ` Tom Tromey
2018-09-24 12:39 ` Eli Zaretskii
2018-09-15 7:25 ` [PATCH 1/7] Allow more Python scalar conversions Tom Tromey
2018-09-24 2:06 ` Simon Marchi
2018-09-24 4:58 ` Tom Tromey
2018-09-15 7:25 ` [PATCH 2/7] Preserve sign when converting gdb.Value to Python int Tom Tromey
2018-09-15 7:25 ` [PATCH 4/7] Report Python errors coming from gdb.post_event Tom Tromey
2018-09-15 7:25 ` [PATCH 3/7] Allow conversion of pointers to Python int Tom Tromey
2018-09-15 7:25 ` [PATCH 6/7] Consolidate gdb.GdbError handling Tom Tromey
2018-09-15 7:25 ` [PATCH 5/7] Check for negative argument in Type.template_argument Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6385b06c-ec1a-3e6e-6b81-a4c0f4097556@simark.ca \
--to=simark@simark.ca \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox