From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1638 invoked by alias); 17 Sep 2014 09:36:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1625 invoked by uid 89); 17 Sep 2014 09:36:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: na01-bn1-obe.outbound.protection.outlook.com Received: from mail-bn1bon0090.outbound.protection.outlook.com (HELO na01-bn1-obe.outbound.protection.outlook.com) (157.56.111.90) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 17 Sep 2014 09:36:18 +0000 Received: from BN1AFFO11FD007.protection.gbl (10.58.52.31) by BN1AFFO11HUB059.protection.gbl (10.58.52.210) with Microsoft SMTP Server (TLS) id 15.0.1019.14; Wed, 17 Sep 2014 09:36:14 +0000 Received: from xsj-pvapsmtpgw01 (149.199.60.83) by BN1AFFO11FD007.mail.protection.outlook.com (10.58.52.67) with Microsoft SMTP Server (TLS) id 15.0.1029.15 via Frontend Transport; Wed, 17 Sep 2014 09:36:13 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-smtp1) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1XUBf3-0000fV-AE; Wed, 17 Sep 2014 02:36:29 -0700 From: Ajit Kumar Agarwal To: Michael Eager , Joel Brobecker CC: "gdb-patches@sourceware.org" , Vinod Kathail , Vidhumouli Hunsigida , "Nagaraju Mekala" Subject: RE: [Patch, microblaze]: Port of Linux gdbserver Date: Wed, 17 Sep 2014 09:36:00 -0000 References: <2570e3c7-f55b-45cd-aa6e-7f4fa145f32a@BN1BFFO11FD002.protection.gbl> <541052B5.5080503@eagercon.com> <20140910134606.GO28404@adacore.com> <050c6461-c35c-441d-9b63-7636d9164e2e@BL2FFO11FD048.protection.gbl> <20140910144313.GP28404@adacore.com> <89d100d8-4ebd-4f50-b5e9-59312124db6a@BL2FFO11FD057.protection.gbl> <54131362.1050009@eagercon.com> <541827A0.7000508@eagercon.com> In-Reply-To: <541827A0.7000508@eagercon.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-RCIS-Action: ALLOW Message-ID: <63539ef8-d2cf-4f1e-baa0-1c10b8b5fd85@BN1AFFO11FD007.protection.gbl> X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(438002)(13464003)(51704005)(24454002)(377454003)(479174003)(199003)(189002)(83322001)(54356999)(87936001)(85306004)(21056001)(4396001)(44976005)(50986999)(99396002)(31966008)(104016003)(20776003)(1496007)(50466002)(74316001)(92726001)(19580395003)(95666004)(64706001)(2656002)(106116001)(77096002)(93886004)(19580405001)(33646002)(76176999)(77982003)(31696002)(6806004)(46102003)(90102001)(23676002)(74662003)(53416004)(70736001)(79102003)(85852003)(47776003)(76482002)(74502003)(81542003)(92566001)(106466001)(107046002)(80022003)(83072002)(86362001)(81342003)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1AFFO11HUB059;H:xsj-pvapsmtpgw01;FPR:;MLV:sfv;PTR:unknown-60-83.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;UriScan:; X-Forefront-PRVS: 0337AFFE9A Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=ajit.kumar.agarwal@xilinx.com; X-OriginatorOrg: xilinx.com X-SW-Source: 2014-09/txt/msg00573.txt.bz2 DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBNaWNoYWVs IEVhZ2VyIFttYWlsdG86ZWFnZXJAZWFnZXJjb24uY29tXSANClNlbnQ6IFR1 ZXNkYXksIFNlcHRlbWJlciAxNiwgMjAxNCA1OjM2IFBNDQpUbzogQWppdCBL dW1hciBBZ2Fyd2FsOyBKb2VsIEJyb2JlY2tlcg0KQ2M6IGdkYi1wYXRjaGVz QHNvdXJjZXdhcmUub3JnOyBWaW5vZCBLYXRoYWlsOyBWaWRodW1vdWxpIEh1 bnNpZ2lkYTsgTmFnYXJhanUgTWVrYWxhDQpTdWJqZWN0OiBSZTogW1BhdGNo LCBtaWNyb2JsYXplXTogUG9ydCBvZiBMaW51eCBnZGJzZXJ2ZXINCg0KT24g MDkvMTUvMTQgMjM6NDEsIEFqaXQgS3VtYXIgQWdhcndhbCB3cm90ZToNCj4N Cj4+PiBXaGF0IGFyZSB0aGUgcmVzdWx0cyBvZiBydW5uaW5nIHRoZSBnZGIg cmVncmVzc2lvbiB0ZXN0IHN1aXRlIHVzaW5nIGdkYnNlcnZlciBvbiB0aGUg dGFyZ2V0IGFmdGVyIGFwcGx5aW5nIHRoaXMgcGF0Y2g/DQo+DQo+IFRoaXMg cGF0Y2ggcmVxdWlyZXMgdGhlIGJlbG93IHBhdGNoZXMgd2hpY2ggYXJlIGFs cmVhZHkgc2VudCB0byBGU0YgdG8gYmUgYXBwbGllZCBmb3IgdGhlIGV4cGVj dGVkIHJlc3VsdHMgd2l0aCBnZGIgcmVncmVzc2lvbiB0ZXN0c3VpdGUuDQo+ IFRoZSBkZXRhaWxzIGFuZCB0aGUgcmVsYXRlZCByZWFzb25zIGFyZSBnaXZl biBiZWxvdy4NCg0KPj5JZiBhIHBhdGNoIGhhcyBwcmVyZXF1aXNpdGVzLCBw bGVhc2UgaWRlbnRpZnkgdGhlbS4NCg0KQWxvbmcgd2l0aCB0aGUgIHR3byBw YXRjaGVzIGdpdmVuIGJlbG93IHRoZSBwYXRjaCBmb3IgbGludXhfcmVtb3Zl X2JyZWFrcG9pbnQgc3VwcG9ydCBhcmUgdGhlIHByZXJlcXVpc2l0ZXMuIA0K DQo+IFtQYXRjaCwgbWljcm9ibGF6ZV0gQWRkIGxpdHRsZS1lbmRpYW4gYnJl YWtwb2ludC4NCj4gW1BhdGNoLCBtaWNyb2JsYXplXTogQWRkIHN1cHBvcnQg b2YgbWljcm9ibGF6ZSBzb2Z0d2FyZSBzaW5nbGUgDQo+IHN0ZXBwaW5nDQo+ DQo+IFRoZSBhYm92ZSBwYXRjaGVzIHdlcmUgYWxyZWFkeSBzZW50IHRvIEZT RiBhbmQgYXJlIHlldCB0byBiZSBhcHBsaWVkLg0KDQo+PlBsZWFzZSByZXNw b25kIHRvIGNvbW1lbnRzIG9uIHRoZSBmaXJzdCBwYXRjaC4NCg0KQXMgc3Vn Z2VzdGVkIHRoZSByZXNwb25zZSBpcyBzZW50IG92ZXIgdGhlIGZpcnN0IHBh dGNoLg0KDQo+PkZvciBzZWNvbmQgcGF0Y2gsIHRoZSB0ZXN0IGNhc2UgeW91 IHByb3ZpZGVkIGRvZXMgbm90IHNob3cgdGhlIGZhaWx1cmUuDQoNCkFzIHRo ZSBjdXJyZW50IHRlc3RjYXNlIHdlIHNlbnQgaXMgbm90IHJlcHJvZHVjaW5n ICB0aGUgaXNzdWUgYXQgeW91ciBlbmQsIHdlIHRoaW5rIHRoZSBjdXJyZW50 IGdkYiB0ZXN0c3VpdGUgZmFpbHVyZXMgYXJlIHRoZSBiZXN0IGV4YW1wbGVz IHRvIHJlcHJvZHVjZSB0aGUgcHJvYmxlbS4NCkFsb25nIHdpdGggdGhlc2Ug dGhyZWUgcGF0Y2hlcyBhbmQgdGhlIGdkYnNlcnZlciBwYXRjaCwgdGhlIGdk YiB0ZXN0c3VpdGVzIHdpbGwgcHJvdmlkZSB0aGUgcmVzdWx0cyBleHBlY3Rl ZC4NCg0KPiBbUGF0Y2gsbWljcm9ibGF6ZV06IEFkZCBzdXBwb3J0IGxpbnV4 X21lbW9yeV9yZW1vdmVfYnJlYWtwb2ludHMuDQo+DQo+IEFzIHN1Z2dlc3Rl ZCBieSBKb2VsICB0byBub3QgdG8gIG1peCB0aGUgIGdkYnNlcnZlciBwYXRj aCB3aXRoIGdkYiBwYXRjaCwgSSB3aWxsIGJlIHNlbmRpbmcgdGhlIHBhdGNo ICJBZGQgU3VwcG9ydCBsaW51eF9tZW1vcnlfcmVtb3ZlX2JyZWFrcG9pbnRz IiBzZXBhcmF0ZWx5Lg0KDQo+Pkkgc3VnZ2VzdCB0aGF0IHlvdSBmaXggcHJv YmxlbXMgd2l0aCB0aGUgcHJldmlvdXMgcGF0Y2hlcyBiZWZvcmUgc3VibWl0 dGluZyBtb3JlLg0KDQpPay4NCg0KPg0KPiBXaXRoIHRoZSBhYm92ZSBtZW50 aW9uZWQgZ2RiIHBhdGNoZXMgIGFuZCB0aGUgZ2Ric2VydmVyIHBhdGNoLCAg YmVsb3cgYXJlIHRoZSByZXN1bHRzLiBBbGwgdGhlIGV4ZWN1dGFibGVzICBh cmUgbGl0dGxlIGVuZGlhbiBiaW5hcmllcyBjb21waWxlZCB3aXRoIG1pY3Jv YmxhemVlbC14aWxpbnV4LWxpbnV4LWdudS4NCj4NCj4gICAgICAgICAgICAg ICAgICA9PT0gZ2RiIFN1bW1hcnkgPT09DQo+DQo+ICMgb2YgZXhwZWN0ZWQg cGFzc2VzICAgICAgICAgICAgODE0Ng0KPiAjIG9mIHVuZXhwZWN0ZWQgZmFp bHVyZXMgICAgICAgIDI0NzANCj4gIyBvZiB1bmV4cGVjdGVkIHN1Y2Nlc3Nl cyAgICAgICAyDQo+ICMgb2YgZXhwZWN0ZWQgZmFpbHVyZXMgICAgICAgICAg Ng0KPiAjIG9mIGtub3duIGZhaWx1cmVzICAgICAgICAgICAgIDIxDQo+ICMg b2YgdW5yZXNvbHZlZCB0ZXN0Y2FzZXMgICAgICAgMjgNCj4gIyBvZiB1bnRl c3RlZCB0ZXN0Y2FzZXMgICAgICAgICA0NA0KPiAjIG9mIHVuc3VwcG9ydGVk IHRlc3RzICAgICAgICAgIDEyNQ0KDQo+PlRoYW5rcy4gIFdoYXQgaXMgeW91 ciB0ZXN0aW5nIGVudmlyb25tZW50Pw0KDQpYaWxpbnV4IFBldGFsaW51eCBL ZXJuZWwgaXMgYm9vdGVkIG9uIGEgS0M3MDUgZGVzaWduLiAgZ2RiIHRlc3Rz dWl0ZSBpcyB1c2luZyB0aGUgIExpbnV4IHRvb2xjaGFpbiAoY29tcGlsZWQg d2l0aCBtaWNyb2JsYXplZWwteGlsaW54LWxpbnV4LWdudShsaXR0bGUtZW5k aWFuKSkuIA0KDQpNaWNoYWVsIEVhZ2VyCSBlYWdlckBlYWdlcmNvbi5jb20N CjE5NjAgUGFyayBCbHZkLiwgUGFsbyBBbHRvLCBDQSA5NDMwNiAgNjUwLTMy NS04MDc3DQo= >From gdb-patches-return-115983-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Sep 17 10:07:59 2014 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 21770 invoked by alias); 17 Sep 2014 10:07:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 21759 invoked by uid 89); 17 Sep 2014 10:07:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 17 Sep 2014 10:07:56 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8HA6man011081 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 17 Sep 2014 06:06:49 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8HA6krO024723; Wed, 17 Sep 2014 06:06:47 -0400 Message-ID: <54195D36.2080001@redhat.com> Date: Wed, 17 Sep 2014 10:07:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: Edjunior Barbosa Machado , gdb-patches@sourceware.org CC: Ulrich Weigand Subject: Re: [PATCH] [PR tdep/17379] Fix internal-error when stack pointer is invalid References: <1410476585-18046-1-git-send-email-emachado@linux.vnet.ibm.com> In-Reply-To: <1410476585-18046-1-git-send-email-emachado@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-09/txt/msg00574.txt.bz2 Content-length: 2411 Hi guys, See https://sourceware.org/bugzilla/show_bug.cgi?id=17384 . When safe_read_memory_integer call fails, GDB prints a surprising/confusing error message, more so in case the unwinder is triggered for some reason other than the "bt" command, like with "step"/"next". I take you're now seeing the same errors with this patch. IMO, printing the error is not something a low-level helper function like safe_read_memory_integer should be doing, as GDB uses it when probing with heuristics because it can't sure its guesses make sense (whether there's a frame at all, etc.) safe_frame_unwind_memory, which is used in rs6000_in_function_epilogue_p doesn't print the error either. Thoughts? Thanks, Pedro Alves On 09/12/2014 12:03 AM, Edjunior Barbosa Machado wrote: > Hi, > > this patch intends to fix PR tdep/17379: > https://sourceware.org/bugzilla/show_bug.cgi?id=17379 > > The problem is that rs6000_frame_cache attempts to read the stack backchain via > read_memory_unsigned_integer, which throws an exception if the stack pointer is > invalid. With this path, it calls safe_read_memory_integer instead, which > doesn't throw an exception and allows for safe handling of that situation. > Regression tested on ppc64{,le}. Ok? > > Thanks and regards, > -- > Edjunior > > gdb/ > 2014-09-11 Edjunior Barbosa Machado > Ulrich Weigand > > PR tdep/17379 > * rs6000-tdep.c (rs6000_frame_cache): Use safe_read_memory_integer > instead of read_memory_unsigned_integer. > > --- > gdb/rs6000-tdep.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c > index 730afe7..dabf448 100644 > --- a/gdb/rs6000-tdep.c > +++ b/gdb/rs6000-tdep.c > @@ -3190,9 +3190,14 @@ rs6000_frame_cache (struct frame_info *this_frame, void **this_cache) > } > > if (!fdata.frameless) > - /* Frameless really means stackless. */ > - cache->base > - = read_memory_unsigned_integer (cache->base, wordsize, byte_order); > + { > + /* Frameless really means stackless. */ > + LONGEST backchain; > + > + if (safe_read_memory_integer (cache->base, wordsize, > + byte_order, &backchain)) > + cache->base = (CORE_ADDR) backchain; > + } > > trad_frame_set_value (cache->saved_regs, > gdbarch_sp_regnum (gdbarch), cache->base);