From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106804 invoked by alias); 26 Jan 2017 16:54:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106794 invoked by uid 89); 26 Jan 2017 16:54:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1384, H*i:sk:0f3b832, H*f:sk:0f3b832, H*MI:sk:0f3b832 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Jan 2017 16:54:56 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cWnK3-0005P8-Eg from Luis_Gustavo@mentor.com ; Thu, 26 Jan 2017 08:54:55 -0800 Received: from [172.30.8.148] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 26 Jan 2017 08:54:52 -0800 Subject: Re: [PATCH/RFC] Refactor gdb.reverse/insn-reverse.c References: <1484593854-1791-1-git-send-email-lgustavo@codesourcery.com> <20170125161011.GW28060@E107787-LIN> <9b4f74b9-b537-7513-2346-817d03075e76@codesourcery.com> <20170125222841.553337r6jhwiybsr@localhost> <0f3b832e-3255-9c02-2aeb-90014865f557@codesourcery.com> To: Luis Machado , Yao Qi CC: Pedro Alves , Reply-To: Luis Machado From: Luis Machado Message-ID: <634bd9ac-86c7-a38e-b3a1-429e0a3d3754@codesourcery.com> Date: Thu, 26 Jan 2017 16:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <0f3b832e-3255-9c02-2aeb-90014865f557@codesourcery.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-02.mgc.mentorg.com (147.34.90.202) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00590.txt.bz2 On 01/26/2017 10:39 AM, Luis Machado wrote: > On 01/25/2017 04:28 PM, Yao Qi wrote: >> On 17-01-25 12:11:01, Luis Machado wrote: >>> That is a reasonable assessment. insn-reverse.[c|exp] is redundant >>> and IMO >>> would benefit from renaming too. >>> >>> The support in "insn-support-.c means support for a set of >>> instructions for this particular subsystem of gdb, therefore why i >>> went with >>> that name. Thinking about it further, instruction decoding support is >>> the >>> basis/foundation of reverse debugging, without which things would not >>> work >>> properly. But i may be overthinking. :-) >> >> Every test is about testing some sort of support. Breakpoint test is >> about breakpoint support, tracepoint test is about tracepoint support. >> We don't have to explicitly mention "support" in the test case name, >> IMO. >> >> It is easy to relate "insn-reverse-.c" to "insn-reverse.c". >> If you think "reverse" is redundant, "insn.c" and "insn-.c" is >> acceptable to me too. >> > > It is not terribly important. I've reverted to the original name > (insn-reverse-.c), updated things to mention the new name and > pushed this as 8b00c176168dc7b0d78d0dc1f7d42f915375dc4a. > > Patch attached. > > Thanks for reviewing, > Luis Forgot to effectively add the files. I'll fix this in a bit.