Re: [PATCH v2 04/25] Introduce interpreter factories

Pedro Alves
2016-05-06T11:49:25Z

Finally getting back to this...

On 03/22/2016 08:55 AM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>> +void
>> +interp_factory_register (const char *name, interp_factory_func func)
>> +{
>> + struct interp_factory *f = XNEW (struct interp_factory);
>> +
>> + f->name = name;
>> + f->func = func;
>> +
>> + /* FIXME: assert that no factory for NAME is already registered. */
>> + VEC_safe_push (interp_factory_p, interpreter_factories, f);
>> +}
>
> It shouldn't be hard to do the assert here, and get rid of the FIXME.
>

Indeed. I fixed this for v3.

Thanks,
Pedro Alves