From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59973 invoked by alias); 17 Oct 2018 23:28:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59955 invoked by uid 89); 17 Oct 2018 23:28:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: resqmta-po-07v.sys.comcast.net Received: from resqmta-po-07v.sys.comcast.net (HELO resqmta-po-07v.sys.comcast.net) (96.114.154.166) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Oct 2018 23:28:56 +0000 Received: from resomta-po-08v.sys.comcast.net ([96.114.154.232]) by resqmta-po-07v.sys.comcast.net with ESMTP id CjeRganpVuIH3CvFGgGooR; Wed, 17 Oct 2018 23:28:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20161114; t=1539818934; bh=IrgsYPfsBDKApxHLFoc1u7jnpgRsE3hJfBmryjXiWeE=; h=Received:Received:Content-Type:Mime-Version:Subject:From:Date: Message-Id:To; b=KH8C5uqa6wmismJghUmQkAE+dqJcXJB3rI/hg0QPQ/eaB1XGjaKN8aiRnasYiNXTM owPqexLo5W8gYxVItjq+CcVB17ELD+k5kQ8QbogKr58LkxVplH3933nWsORzEqreh2 iQcEa2IjRsp1Crgg/t4LodMlcrDFd7+J2enG0/6bCcJCd9on4d0kx4O7/OcSAsL369 yuQHyZlsuK1j/mUA7zim5VgPogjKSurXJamWYnmDE5Zw1ghvpBh4SdNN5QzafCJzNz vivEMMLEXX9Mw9/1a/QkKMyUhn6PvDcCiZf+WwXXuZvb6hrQoXlD40fIYKHnrNeC2k ifCZ0ZvCVGnIg== Received: from [192.168.10.125] ([73.60.223.101]) by resomta-po-08v.sys.comcast.net with ESMTPSA id CvFFgYXnAseObCvFGgYzcw; Wed, 17 Oct 2018 23:28:54 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: [PATCH][gdb] fix unsigned overflow in charset.c From: Paul Koning In-Reply-To: <0addc221-09f0-36e0-9bf4-370472a23a53@redhat.com> Date: Wed, 17 Oct 2018 23:28:00 -0000 Cc: John Baldwin , gdb-patches@sourceware.org Content-Transfer-Encoding: quoted-printable Message-Id: <632E97DF-4786-44A0-BD78-76EEB6BF650A@comcast.net> References: <7B48D309-445E-4141-A87A-1F3D5FA70EFD@comcast.net> <1acace4a-a5c6-abaf-f070-9c2e6768b6f2@redhat.com> <9ea7a1f6-5c3f-c569-6bba-ca9e21711de1@FreeBSD.org> <2DCE0AB8-5647-4AD1-B0AA-3A8350C3BE6D@comcast.net> <17fcbb42-d694-af87-9a8d-d01addee992b@FreeBSD.org> <42e6b4b2-fb05-25f6-ef0a-73ce854116de@redhat.com> <31fcba01-1f2c-d932-94f2-69b7cb14601a@FreeBSD.org> <15814BE7-1C4F-4067-99A5-A004D094FB96@comcast.net> <0addc221-09f0-36e0-9bf4-370472a23a53@redhat.com> To: Pedro Alves X-SW-Source: 2018-10/txt/msg00388.txt.bz2 > On Oct 17, 2018, at 5:51 PM, Pedro Alves wrote: >=20 > On 10/17/2018 07:47 PM, Paul Koning wrote: >>=20 >>=20 >>> On Oct 17, 2018, at 2:38 PM, John Baldwin wrote: >>>=20 >>>> ... >>>> From an aesthetic perspective, "ssize_t" seems better, as the "obvious >>>> signed version of size_t". From a pedantic perspective, ptrdiff_t >>>> sounds better. >>>=20 >>> Ok, I think ssize_t is probably fine, so I Think Paul's original patch = is >>> ok? >>>=20 >>> --=20 >>> John Baldwin >>=20 >> Please let me know; I can commit that patch if it is approved. Or commi= t with changes if that's desired. >=20 > Patch is OK as is. Please push. >=20 > Thanks, > Pedro Alves Thank you. Done.=20=20 paul