From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ya1dNnL9lmrlWRsAWB0awg (envelope-from ) for ; Tue, 01 Sep 2026 12:29:38 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=rA3t2vXT; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=CbDv2zmY; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=j7M5BSRW; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=fEWTPDu1; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D408D1E166; Tue, 01 Sep 2026 12:29:38 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1A4641E033 for ; Tue, 01 Sep 2026 12:29:38 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 52F5F4BA23E2 for ; Tue, 1 Sep 2026 16:29:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 52F5F4BA23E2 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=rA3t2vXT; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=CbDv2zmY; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=j7M5BSRW; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=fEWTPDu1 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 40E454BA540B for ; Tue, 1 Sep 2026 16:29:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 40E454BA540B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 40E454BA540B Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788280153; cv=none; b=XT+MkKxAkgjMmkNB++UqviwvF8JIrAyv6Gz1Y6MrZBInfzczVQ/7FzT2hVofryKH3iDl/km1UmWoKRgsfYcMZN7ZTvaZqvC2PmhYz/VFWEufgKoNi8snfq4ZwP9qWklw445/F7txOcFBRYGGXrLhcAtGNzBGF1HoAQjLQ0Epma0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788280153; c=relaxed/simple; bh=Ru9pJnES43KFJPbDK3Tip7HE618Q7b5zDn9ba6lgVEc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=nYO3Mg8naMqEIb/hfoOGct76kbXprrZQ6H1r0rNKUuysVM0EZyI5zaBLixQbevRb5Cpn1t66sCkr0m5N7qjAkl2hVaLt9nEw9KHrsTyTkg2lMlUbaNqaXGYMLpW2z+28MeGyBkd3/E4sNSxaVhP/vAzrNUy9cavPokQN57X4Tps= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=rA3t2vXT; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=CbDv2zmY; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=j7M5BSRW; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=fEWTPDu1 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 40E454BA540B Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B6B471F7A7; Tue, 1 Sep 2026 16:29:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788280147; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7V2LG9uXgYv3nTHZsiC21tnGibb7ZrM1G1xD+Vy4xKo=; b=rA3t2vXTfyEmUE74Cbjx/IkL2vnFEHgtYLSWlOcVCqANajQKaFZJQn/N6XeZDGcBgD3yn6 ncPDFumg5YvXlKfSvQALHQTE5VWVsCOnblHXqsCZ8CHMYcHMQcrpH+Z9MEyzYw21vDzW1+ ju4Dk4mf7eCZnnvs7zZYGFlwycvN//I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788280147; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7V2LG9uXgYv3nTHZsiC21tnGibb7ZrM1G1xD+Vy4xKo=; b=CbDv2zmYGZrG/ctTMK+q6QkfzvFPfN5QdWJgaxDeAXxMe/bvRrJR+1dCbCfVFor9472g/C 5edQqVMcGxcaC9Cg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=j7M5BSRW; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=fEWTPDu1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788280143; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7V2LG9uXgYv3nTHZsiC21tnGibb7ZrM1G1xD+Vy4xKo=; b=j7M5BSRWpd+GoGtcG5zjWEEaDyCfFtrxtTKL0WtGBZ2lnv2NxZqU2kmoU8WUTVW8nrli9o sV5js+vRD2hQhOjEhUY86oI+DXyPAeB0uExVc1YofSv270EwZRC2pwih7o/X+EZh/gUbCE 0HlJ7jIehGsmVXbCYAs/dGzRgHC3NYE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788280143; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7V2LG9uXgYv3nTHZsiC21tnGibb7ZrM1G1xD+Vy4xKo=; b=fEWTPDu1LWnW36WGht82Mry7rQ1tAqNjyHUR1ADhY2jGyZK+rMMs87P5axJ5ozbNBTYK+N 9NGkHRT41hdPC/BQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 86C4D1369E; Tue, 1 Sep 2026 16:29:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id nd2CH0/9lmr2agAAD6G6ig (envelope-from ); Tue, 01 Sep 2026 16:29:03 +0000 Message-ID: <6327e89f-223a-48bc-bbf1-65cdab61e707@suse.de> Date: Tue, 1 Sep 2026 18:29:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [pushed] [gdb/contrib] Make cc-with-tweaks.sh shellcheck-clean To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260831091132.3513640-1-tdevries@suse.de> <87cxux7xbk.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87cxux7xbk.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: B6B471F7A7 X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email,suse.de:mid,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; URIBL_BLOCKED(0.00)[suse.de:dkim,suse.de:email,suse.de:mid,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/1/26 6:25 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> Make gdb/contrib/cc-with-tweaks.sh shellcheck-clean by adding some quotes. > > Tom> diff --git a/gdb/contrib/cc-with-tweaks.sh b/gdb/contrib/cc-with-tweaks.sh > Tom> index 57fd51354bc..047c748e165 100755 > Tom> --- a/gdb/contrib/cc-with-tweaks.sh > Tom> +++ b/gdb/contrib/cc-with-tweaks.sh > Tom> @@ -335,4 +335,4 @@ if [ "$want_gnu_debuglink" = true ]; then > Tom> [ $rc != 0 ] && exit $rc > Tom> fi > > Tom> -exit $rc > Tom> +exit "$rc" > > I wonder why the quotes are needed here but not in the quoted line > above. The def that reaches this use is: ... rc=${PIPESTATUS[0]} ... and shellcheck doesn't treat that specially, at least in the context of this check. Thanks, - Tom