From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32127 invoked by alias); 16 Oct 2003 19:02:13 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32118 invoked from network); 16 Oct 2003 19:02:12 -0000 Received: from unknown (HELO mail-out3.apple.com) (17.254.13.22) by sources.redhat.com with SMTP; 16 Oct 2003 19:02:12 -0000 Received: from mailgate1.apple.com (a17-128-100-225.apple.com [17.128.100.225]) by mail-out3.apple.com (8.12.10/8.12.9) with ESMTP id h9GJ2Bk0003646 for ; Thu, 16 Oct 2003 12:02:11 -0700 (PDT) Received: from scv2.apple.com (scv2.apple.com) by mailgate1.apple.com (Content Technologies SMTPRS 4.2.1) with ESMTP id for ; Thu, 16 Oct 2003 12:01:40 -0700 Received: from [17.201.22.245] (inghji6.apple.com [17.201.22.245]) by scv2.apple.com (8.12.9/8.12.9) with ESMTP id h9GJ1uWI007432 for ; Thu, 16 Oct 2003 12:01:56 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v606) In-Reply-To: <1066321046.18949.ezmlm@sources.redhat.com> References: <1066321046.18949.ezmlm@sources.redhat.com> Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <631CE16C-000B-11D8-BB88-000A958F4C44@apple.com> Content-Transfer-Encoding: 7bit From: Jim Ingham Subject: Re: RFA: Breakpoint infrastructure cleanups [0/8] Date: Thu, 16 Oct 2003 19:02:00 -0000 To: gdb-patches@sources.redhat.com X-SW-Source: 2003-10/txt/msg00558.txt.bz2 I would be careful to stay away from turning "logically" specified breakpoints (by which I mean specified on function name or source location) into addresses to the user. Even between rerunnings of the same executable a library's load address can shift, causing the address to move. gdb can probably still make the equivalency between the breakpoints - most slides are rigid, for instance. But the address doesn't show this. I would use something simble like 5a, 5b or whatever... Jim On Oct 16, 2003, at 9:17 AM, gdb-patches-digest-help@sources.redhat.com wrote: >> From: Elena Zannoni >> Date: Thu, 16 Oct 2003 10:32:57 -0400 >> >> Just occurred to me that maybe the user sometimes would want to set a >> breakpoint in just one particular instance of an inlined function, we >> should still allow that. > > How about the following? > > (gdb) break inline_foo > Breakpoint 5 set at inline_foo, which has multiple locations. > Say "info breakpoint 5" for more details. > (gdb) info break 5 > Num Type Enb Address What > 5 sw breakpoint y 0x8040222 inlined into foo > 5 sw breakpoint y 0x8040822 inlined into bar > 5 sw breakpoint y 0x8040852 inlined into boring_loop > (gdb) delete 5 *0x8040852 > >> I.e. should setting the multiple breakpoints >> be the default? > > I think this is the best default, yes. > > Alternatively, we could show all possible addresses where the > requested breakpoint coulod be set and ask the user to select which > ones she wants, like this: > > (gdb) break inline_foo > Function inline_foo is inlined into multiple locations: > Address Location > 0x8040222 inlined into foo > 0x8040822 inlined into bar > 0x8040852 inlined into boring_loop > Please use "break *address" to set breakpoints at one or more of these > (gdb) break *0x8040822 *0x8040822 > -- Jim Ingham jingham@apple.com Developer Tools Apple Computer