From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71178 invoked by alias); 27 Jun 2017 11:52:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71159 invoked by uid 89); 27 Jun 2017 11:52:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Jun 2017 11:52:17 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C28A43B73E; Tue, 27 Jun 2017 11:52:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C28A43B73E Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C28A43B73E Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 29C287BAE1; Tue, 27 Jun 2017 11:52:14 +0000 (UTC) Subject: Re: [PATCH 05/40] command.h: Include scoped_restore_command.h To: Yao Qi References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-6-git-send-email-palves@redhat.com> <86bmp9fz0z.fsf@gmail.com> <684b5ca4-590b-d375-93f5-b66e86ec33a1@redhat.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <6314192d-2f8e-cfd1-18ea-362cf2b59374@redhat.com> Date: Tue, 27 Jun 2017 11:52:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <684b5ca4-590b-d375-93f5-b66e86ec33a1@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2017-06/txt/msg00722.txt.bz2 On 06/27/2017 12:45 PM, Pedro Alves wrote: > > On 06/27/2017 12:30 PM, Yao Qi wrote: >> Pedro Alves writes: >> >>> This file depends on scoped_restore: >>> >>> extern scoped_restore_tmpl prevent_dont_repeat (void); >>> >>> But doesn't include the corresponding header. >> >> It is a function declaration, so why does it need scoped_restore? > > I don't understand. Why wouldn't it? If the compiler doesn't > know what scoped_restore_tmpl is, how can that compile? > >> >> $ make check-headers CHECK_HEADERS="command.h" >> >> The command above doesn't complain anything. I tried gcc-5, 6, and 7. > > Odd. Let me take another look. OK, so defs.h includes utils.h, which includes scoped_restore.h, as found via this hack: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git c/gdb/command.h w/gdb/command.h index aa179e9..f587ebd 100644 --- c/gdb/command.h +++ w/gdb/command.h @@ -415,6 +415,8 @@ extern void error_no_arg (const char *) ATTRIBUTE_NORETURN; extern void dont_repeat (void); +template union scoped_restore_tmpl; + extern scoped_restore_tmpl prevent_dont_repeat (void); /* Used to mark commands that don't do anything. If we just leave the ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/gdb/command.h:418:29: error: ‘union’ tag used in naming ‘struct scoped_restore_tmpl’ [-fpermissive] template union scoped_restore_tmpl; ^ In file included from src/gdb/utils.h:25:0, from src/gdb/defs.h:785, from :0: src/gdb/common/scoped_restore.h:50:7: note: ‘struct scoped_restore_tmpl’ was previously declared here class scoped_restore_tmpl : public scoped_restore_base ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > I ran into this because at some point I added "#include "command.h" > somewhere, which then failed to compile. I don't remember exactly where I added the #include "command.h" that triggered this. Must have been somewhere that caused "command.h" to be included via "defs.h", before the "#include utils.h" line. Let me try removing it from the series, see if I can still reproduce it. Thanks, Pedro Alves