From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107814 invoked by alias); 5 Jul 2018 19:01:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106337 invoked by uid 89); 5 Jul 2018 19:01:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Jul 2018 19:01:27 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0931530E4EAF; Thu, 5 Jul 2018 19:01:26 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BC48867659; Thu, 5 Jul 2018 19:01:25 +0000 (UTC) Subject: Re: [RFA 06/42] Move have_line_numbers to buildsym_compunit To: Tom Tromey , gdb-patches@sourceware.org References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-7-tom@tromey.com> From: Keith Seitz Message-ID: <62ee17d0-af6d-5fde-855f-52b9a8d87189@redhat.com> Date: Thu, 05 Jul 2018 19:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180523045851.11660-7-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00126.txt.bz2 Hi, I have just one trivial request: On 05/22/2018 09:58 PM, Tom Tromey wrote: > diff --git a/gdb/buildsym.c b/gdb/buildsym.c > index c3961254da..d0dfa4cd02 100644 > --- a/gdb/buildsym.c > +++ b/gdb/buildsym.c > @@ -1288,7 +1286,7 @@ end_symtab_get_static_block (CORE_ADDR end_addr, int expandable, int required) > && pending_blocks == NULL > && file_symbols == NULL > && global_symbols == NULL > - && have_line_numbers == 0 > + && buildsym_compunit->m_have_line_numbers == 0 > && buildsym_compunit->m_pending_macros == NULL > && global_using_directives == NULL) > { Since m_have_line_numbers was declared bool, I prefer (and I think most do?) that the comparison use `false' instead. Keith