From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4593 invoked by alias); 25 Jan 2017 14:36:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4475 invoked by uid 89); 25 Jan 2017 14:36:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=bah, H*f:sk:e7a77d2, H*MI:sk:e7a77d2, H*i:sk:e7a77d2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Jan 2017 14:35:50 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4CBC83DBCA; Wed, 25 Jan 2017 14:35:50 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v0PEZisb019971; Wed, 25 Jan 2017 09:35:44 -0500 Subject: Re: [PATCH v2 2/2] btrace: allow recording to be started for running threads To: Markus Metzger , gdb-patches@sourceware.org References: <1484923135-31270-1-git-send-email-markus.t.metzger@intel.com> <1484923135-31270-3-git-send-email-markus.t.metzger@intel.com> Cc: Simon Marchi From: Pedro Alves Message-ID: <62ba62e9-d88d-6ce0-52f4-f8d8d3345d87@redhat.com> Date: Wed, 25 Jan 2017 14:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-01/txt/msg00528.txt.bz2 On 01/25/2017 02:32 PM, Pedro Alves wrote: >> +# Check that recording was started on each thread. >> +foreach thread {1 2 3 4} { >> + check_tracing_enabled $thread > > Looks like this is adding duplicate test messages? See: > > https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique Bah, somehow missed the with_test_prefix inside the proc. Ignore this remark. Thanks, Pedro Alves