Re: [PATCH] Implement IP_STAT on NetBSD

[Simon Marchi <simark@simark.ca>]

On 2020-04-13 4:26 p.m., Kamil Rytarowski wrote:
> On 13.04.2020 22:11, Simon Marchi wrote:
>>> This compat shim is only to emulate Linux... it's possible to follow the
>>> FreeBSD case and just print local kinfo_proc2 as-is (that is fully
>>> OS-specific).
>>>
>>> What do you think?
>>>
>>> The same question applies to IP_STATUS.
>> When you put it like this... it just seems useless to read the info from /proc.
>>
>> If sysctl is guaranteed to always be there and is the blessed way of getting the
>> information, then let's just use that.
> 
> As the kernel emulates Linux in /proc, the stat file is more complete in
> the kernel as there are missing fields (sys/rusage.h ones, eip, esp,
> stack position etc)

Ok, so if you'd like to have this extra information printed, then it could make
sense to try /proc first (if you think it's worth the extra complexity).

>>  The goal is not to emulate Linux, but to
>> use each OS's interface to get the required information.
> 
> Is it fine to print NetBSD specific internals from kinfo_proc2 in
> NetBSD-specific format? Making up Linux-like output will be always
> imperfect, but on the other hand end-users can be confused.

You would have to give some specific examples, but in general it's fine for different
OSes to print different information.  If some process property only exists in NetBSD,
then it should be printed here.  If some process property exists in Linux but not
NetBSD, then it should not be printed here.  Although when we print the same things, we
should strive to print them in a consistent way.

Simon