From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YvXzNTgDxWlVEToAWB0awg (envelope-from ) for ; Thu, 26 Mar 2026 05:58:16 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=KsebhPZY; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=oeff9a8S; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=KsebhPZY; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=oeff9a8S; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C75491E04F; Thu, 26 Mar 2026 05:58:16 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9BC351E04F for ; Thu, 26 Mar 2026 05:58:15 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id D53724BA23C5 for ; Thu, 26 Mar 2026 09:58:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D53724BA23C5 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=KsebhPZY; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=oeff9a8S; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=KsebhPZY; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=oeff9a8S Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 95CB44BA2E12 for ; Thu, 26 Mar 2026 09:57:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 95CB44BA2E12 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 95CB44BA2E12 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774519067; cv=none; b=wkvd+twgkX2zCPeeXY5q8tsTK3trrkvVHEGji5szWbRbWjCJVkSO60+zbNJlEeARbLV4Kpwh/d8FE1Z6BUshcCSksd6mUPxiD7nAd5mc/Dd621XreeBMEk6/rJofV85XDLr3V8qboy79UMcY5oppyvVWc6BdzxNJ9e8Z9LqSnGc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774519067; c=relaxed/simple; bh=qpKOvgYJnNMUa/IiN4IZx9JJv1ZEgfruFaXkZ7hT/GQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=iq14Dn7iuGX2YaZjBd7B1qVd8ueoXfVqsXWchjg++iBZ7WQXSvdAorgyjEupsszRVPhF8J++5CSPK69OZdQ8pwcvxKCiJeL2sXKX4wX+emWmTZkfJKy0eJV7djNeANJJSuhZnDvlIqR7oZ+k4vUXIrqgS1NIkLgZO2NnxT42hng= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 95CB44BA2E12 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 786595BD0A; Thu, 26 Mar 2026 09:57:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774519066; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3IbWLynJpoD2nRkEBpUrRyUSbrspvoxKKLlVPHCAJ4A=; b=KsebhPZYf9ACscgs7SWiusBsVj0Cw32k4gTItMsU5qbttkzDllMlXHA1+90LKYUL1qKirg c22GKeNf2ejnX96OyPLvEeu7ChWRnaU5TzGAThDFbmtEOamX9WFcxXG2cxraLgdZmvlaf3 iuXyNHexSGRLc0ffF2Bi4aimunIgQMU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774519066; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3IbWLynJpoD2nRkEBpUrRyUSbrspvoxKKLlVPHCAJ4A=; b=oeff9a8SB2AznUFoA5B+4H3RxAhxYXFoxGdxIqXv6w9arLyoS/queJ2myG/J79IdxMqfrE /ogHUnb47zxrGcCg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=KsebhPZY; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=oeff9a8S DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774519066; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3IbWLynJpoD2nRkEBpUrRyUSbrspvoxKKLlVPHCAJ4A=; b=KsebhPZYf9ACscgs7SWiusBsVj0Cw32k4gTItMsU5qbttkzDllMlXHA1+90LKYUL1qKirg c22GKeNf2ejnX96OyPLvEeu7ChWRnaU5TzGAThDFbmtEOamX9WFcxXG2cxraLgdZmvlaf3 iuXyNHexSGRLc0ffF2Bi4aimunIgQMU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774519066; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3IbWLynJpoD2nRkEBpUrRyUSbrspvoxKKLlVPHCAJ4A=; b=oeff9a8SB2AznUFoA5B+4H3RxAhxYXFoxGdxIqXv6w9arLyoS/queJ2myG/J79IdxMqfrE /ogHUnb47zxrGcCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 60CE04A0A3; Thu, 26 Mar 2026 09:57:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id w+doFhoDxWlNZAAAD6G6ig (envelope-from ); Thu, 26 Mar 2026 09:57:46 +0000 Message-ID: <62794ee3-ffc9-4bbc-959f-bee3f06947e5@suse.de> Date: Thu, 26 Mar 2026 10:57:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] [gdb] Add c_ctrl/c_unctrl To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260325123946.4072546-1-tdevries@suse.de> <87a4vv6c58.fsf@tromey.com> <871ph766cu.fsf@tromey.com> <87h5q3prav.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87h5q3prav.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 786595BD0A X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/25/26 9:50 PM, Tom Tromey wrote: > Tom> I could make this pass somehow, but I don't know how because I don't > Tom> understand what we're actually trying to test here. > > Tom> That is, we're already testing all input values. What else is there > Tom> to test? > >> The point is that the function should be a black box and that sign >> extension of chars (on some platforms at least) is the case that >> required this. > >> But let's just go ahead. I don't really care that much. > > Sorry about this. This didn't really come out right. > Hi Tom, no worries, I understood it as a technical comment. > What I mean is that the benefit of black-box testing is probably > minimal. So I think there's not much point to doing what I suggested. I've pushed the patch, but I may submit a follow-up patch implementing (my current understanding of) your suggestion. Thanks for the review. - Tom