From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91525 invoked by alias); 29 Nov 2018 18:12:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91504 invoked by uid 89); 29 Nov 2018 18:12:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:928 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Nov 2018 18:12:32 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9F42DC0C0578; Thu, 29 Nov 2018 18:12:31 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5B2B37D879; Thu, 29 Nov 2018 18:12:29 +0000 (UTC) Subject: Re: [PATCH 3/4] gdb/riscv: Create each unique target description only once To: Andrew Burgess , gdb-patches@sourceware.org References: <84ce42bd83dc3d67bd312c4c8772171dd5bf1182.1543509416.git.andrew.burgess@embecosm.com> Cc: jimw@sifive.com, palmer@sifive.com, jhb@FreeBSD.org From: Pedro Alves Message-ID: <6277aa2c-c64e-e7d2-07d9-444ce80ef170@redhat.com> Date: Thu, 29 Nov 2018 18:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <84ce42bd83dc3d67bd312c4c8772171dd5bf1182.1543509416.git.andrew.burgess@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-11/txt/msg00541.txt.bz2 On 11/29/2018 04:48 PM, Andrew Burgess wrote: > + > + /* Add TDESC into the cache, a target description created to match > + FEATURES. */ > + void add (const struct riscv_gdbarch_features features, > + const target_desc *tdesc) > + { > + feature_tdesc_pair p (features, tdesc); > + m_tdesc_list.push_back (p); > + } > + > +private: > + > + /* Map from a feature set to the corresponding target description. */ > + typedef std::pair + const target_desc *> feature_tdesc_pair; > + > + /* List of all target descriptions we've previously seen. */ > + std::vector m_tdesc_list; > +}; Did you consider an unordered_map instead of this whole class here? See xml-tdesc.c's xml_cache. If there's a reason the custom data structure is preferred, I think that warrants a comment. Thanks, Pedro Alves