Re: [PATCH 1/3] gcore: add -v or --version option to show version number

Eli Zaretskii
2025-03-06T17:32:00Z

> From: Andrew Burgess <aburgess@redhat.com>
> Cc: Andrew Burgess <aburgess@redhat.com>
> Date: Thu, 6 Mar 2025 17:10:22 +0000
>
> Based on the work in this commit:
>
> commit fb2ded33c1e519659743047ed7817166545b6d91
> Date: Fri Dec 20 12:46:11 2024 -0800
>
> Add gstack script
>
> This commit adds a '-v' or '--version' option to the existing gcore
> script. This new option causes the script to print its version
> number, and then exit.
>
> I needed to adjust the getopts handling a little in order to support
> the long form '--version' argument, but as this makes gcore more
> consistent with gstack, then this seems like a good thing.
>
> The usage message is now getting a little long. Don't worry, I plan
> to clean that up in the next commit.
> ---
> gdb/Makefile.in | 7 ++-----
> gdb/NEWS | 3 +++
> gdb/configure | 5 ++---
> gdb/configure.ac | 2 +-
> gdb/doc/gdb.texinfo | 7 ++++++-
> gdb/{gcore.in => gcore-1.in} | 23 ++++++++++++++++++++---
> 6 files changed, 34 insertions(+), 13 deletions(-)
> rename gdb/{gcore.in => gcore-1.in} (88%)

Thanks, the documentation parts are okay.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>