From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 9A506388F046 for ; Thu, 4 Jun 2020 19:23:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9A506388F046 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 235371E791; Thu, 4 Jun 2020 15:23:36 -0400 (EDT) Subject: Re: [PATCH v2] [gdb] Support frames inlined into the outer frame From: Simon Marchi To: Scott Linder , gdb-patches@sourceware.org References: <41baeec4e477b1287e331e58adb9abf4@scottlinder.com> <20200331191856.31222-1-scott@scottlinder.com> <9e2832f3-c3c4-76da-9c40-85b8055bdee5@simark.ca> Message-ID: <6273d9f5-5c42-620b-daff-c332ab148623@simark.ca> Date: Thu, 4 Jun 2020 15:23:35 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <9e2832f3-c3c4-76da-9c40-85b8055bdee5@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jun 2020 19:23:37 -0000 On 2020-06-04 12:11 p.m., Simon Marchi wrote: > On 2020-03-31 3:18 p.m., Scott Linder wrote: >> @@ -763,6 +760,24 @@ frame_id_eq (struct frame_id l, struct frame_id r) >> return eq; >> } >> >> +int >> +outer_frame_id_p (struct frame_id l) >> +{ >> + int p; >> + >> + /* The artificial_depth can vary so we ignore it when checking if this is >> + an outer_frame_id. */ >> + l.artificial_depth = 0; >> + p = memcmp (&l, &outer_frame_id, sizeof (outer_frame_id)); > > This should be `memcmp (...) == 0`. Currently, the function returns true when > the frame is not an outer frame id, which is the opposite of what it is supposed > to do. > > With this, the test gdb.base/break.exp on AArch64 runs fine. I will launch a full > test run to see if there are any other problems. > > You can make the new function return "bool" instead of "int", and use true/false instead > of zero/non-zero (both in the code and comments). > > Simon With this change, the full test run on AArch64 came out clean. I'll try a try job on the buildbot, but I haven't had much success with it recently. Simon