From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 924F6385E006 for ; Fri, 27 Mar 2020 13:11:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 924F6385E006 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C092B1E5F9; Fri, 27 Mar 2020 09:11:34 -0400 (EDT) Subject: Re: [PATCH 1/2] gdbsupport: Resolve shellcheck issues in create-version.sh script To: Andrew Burgess , gdb-patches@sourceware.org Cc: Joel Brobecker References: <0784fb919936e8e5afa466c7597c37c574a44bb9.1585311874.git.andrew.burgess@embecosm.com> From: Simon Marchi Message-ID: <62636013-06cb-ec3e-132d-780c307f1fb5@simark.ca> Date: Fri, 27 Mar 2020 09:11:33 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <0784fb919936e8e5afa466c7597c37c574a44bb9.1585311874.git.andrew.burgess@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US-large Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-26.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Mar 2020 13:11:36 -0000 On 2020-03-27 8:27 a.m., Andrew Burgess wrote: > Run shellcheck (version 0.4.7) on the create-version.sh script, and > resolve the issues it highlighter - they all seemed reasonable. > > gdbsupport/ChangeLog: > > * create-version.sh: Resolve issues highlighted by shellcheck. > --- > gdbsupport/ChangeLog | 4 ++++ > gdbsupport/create-version.sh | 18 ++++++++++-------- > 2 files changed, 14 insertions(+), 8 deletions(-) > > diff --git a/gdbsupport/create-version.sh b/gdbsupport/create-version.sh > index 81d6dbf8c1f..6135d219d94 100755 > --- a/gdbsupport/create-version.sh > +++ b/gdbsupport/create-version.sh > @@ -27,12 +27,14 @@ host_alias="$2" > target_alias="$3" > output="$4" > > -rm -f version.c-tmp $output version.tmp > -date=`sed -n -e 's/^.* BFD_VERSION_DATE \(.*\)$/\1/p' $srcdir/../bfd/version.h` > -sed -e "s/DATE/$date/" < $srcdir/version.in > version.tmp > -echo '#include "gdbsupport/version.h"' >> version.c-tmp > -echo 'const char version[] = "'"`sed q version.tmp`"'";' >> version.c-tmp > -echo 'const char host_name[] = "'"$host_alias"'";' >> version.c-tmp > -echo 'const char target_name[] = "'"$target_alias"'";' >> version.c-tmp > -mv version.c-tmp $output > +rm -f version.c-tmp "$output" version.tmp > +date=$(sed -n -e 's/^.* BFD_VERSION_DATE \(.*\)$/\1/p' "$srcdir/../bfd/version.h") > +sed -e "s/DATE/$date/" < "$srcdir/version.in" > version.tmp > +{ > + echo '#include "gdbsupport/version.h"' > + echo 'const char version[] = "'"$(sed q version.tmp)"'";' > + echo 'const char host_name[] = "'"$host_alias"'";' > + echo 'const char target_name[] = "'"$target_alias"'";' > +} >> version.c-tmp > +mv version.c-tmp "$output" > rm -f version.tmp > -- > 2.14.5 > Thanks, I think it's probably worth pushing this patch right away, it's an improvement in its own right. Simno