From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Constify target_pass_signals and target_program_signals
Date: Mon, 14 Jan 2019 22:03:00 -0000 [thread overview]
Message-ID: <61eb8b1849ceb9a9137524067ea233d8@polymtl.ca> (raw)
In-Reply-To: <20190106224636.5271-2-tom@tromey.com>
On 2019-01-06 17:46, Tom Tromey wrote:
> This constifies the final parameter to target_pass_signals and
> target_program_signals and updates the rest of gdb.
>
> Note that I have no way to test the nto-procfs.c change.
This LGTM. Even if there was a typo, it would be a trivial fix.
Simon
next prev parent reply other threads:[~2019-01-14 22:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-06 22:46 [PATCH 0/3] Some remote-related constification Tom Tromey
2019-01-06 22:46 ` [PATCH 2/3] Constify remote_console_output Tom Tromey
2019-01-06 22:46 ` [PATCH 3/3] Constify some remote-notif functions Tom Tromey
2019-01-06 22:46 ` [PATCH 1/3] Constify target_pass_signals and target_program_signals Tom Tromey
2019-01-14 22:03 ` Simon Marchi [this message]
2019-01-15 0:31 ` Tom Tromey
2019-01-23 18:46 ` [PATCH] target_pass_signals/target_program_signals: Use gdb::array_view (Re: [PATCH 1/3] Constify target_pass_signals and target_program_signals) Pedro Alves
2019-01-23 22:02 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61eb8b1849ceb9a9137524067ea233d8@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox