From: Ulrich Weigand via Gdb-patches <gdb-patches@sourceware.org>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Aditya Kamath1 <Aditya.Kamath1@ibm.com>
Cc: Sangamesh Mallayya <sangamesh.swamy@in.ibm.com>
Subject: Re: [PATCH] Enable-vector-register-visibility-in-core-file-for-AIX.patch
Date: Tue, 14 Mar 2023 17:58:26 +0000 [thread overview]
Message-ID: <61e5844bc9b0acb8f548608d8c5f9e1f534c9efb.camel@de.ibm.com> (raw)
In-Reply-To: <CH2PR15MB3544FAA00A7D77D2CE1BE354D6BE9@CH2PR15MB3544.namprd15.prod.outlook.com>
Aditya Kamath1 <Aditya.Kamath1@ibm.com> wrote:
>Kindly check in this patch.. It is a simple check to see for
>aix-vmx or vsx presence in a bfd file. And then we return
>the required target desc.
The function looks reasonable, but it's in the wrong file -
you still install it unconditionally on all operating systems.
Instead, this function should go to rs6000-aix-tdep.c (next
to rs6000_aix_iterate_over_regset_sections) and should be
installed from rs6000_aix_init_osabi.
Bye,
Ulrich
next prev parent reply other threads:[~2023-03-14 17:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 12:23 Aditya Kamath1 via Gdb-patches
2023-03-13 13:06 ` Ulrich Weigand via Gdb-patches
2023-03-14 7:43 ` Aditya Kamath1 via Gdb-patches
2023-03-14 17:58 ` Ulrich Weigand via Gdb-patches [this message]
2023-03-15 4:54 ` Aditya Kamath1 via Gdb-patches
2023-03-15 18:32 ` Ulrich Weigand via Gdb-patches
2023-03-15 19:04 ` Simon Marchi via Gdb-patches
2023-03-16 12:50 ` Luis Machado via Gdb-patches
2023-03-16 13:51 ` Tom Tromey
2023-03-16 15:11 ` Ulrich Weigand via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61e5844bc9b0acb8f548608d8c5f9e1f534c9efb.camel@de.ibm.com \
--to=gdb-patches@sourceware.org \
--cc=Aditya.Kamath1@ibm.com \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=sangamesh.swamy@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox