From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25481 invoked by alias); 7 Jan 2018 15:46:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25472 invoked by uid 89); 7 Jan 2018 15:45:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:444, XML, visitors X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 07 Jan 2018 15:45:58 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w07FjpfC019369 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 7 Jan 2018 10:45:56 -0500 Received: by simark.ca (Postfix, from userid 112) id 6DDE71E093; Sun, 7 Jan 2018 10:45:51 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 3B7931E093 for ; Sun, 7 Jan 2018 10:45:50 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sun, 07 Jan 2018 15:46:00 -0000 From: Simon Marchi To: gdb-patches@sourceware.org Subject: Re: [PATCH] Replace VEC(gdb_xml_value_s) with std::vector In-Reply-To: <20171202164937.13641-1-simon.marchi@polymtl.ca> References: <20171202164937.13641-1-simon.marchi@polymtl.ca> Message-ID: <61e4f3cd6dd6315133c8d703001d254a@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.2 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 7 Jan 2018 15:45:51 +0000 X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00139.txt.bz2 On 2017-12-02 11:49, Simon Marchi wrote: > This patch replaces VEC(gdb_xml_value_s), which is passed to XML > visitors, with an std::vector. In order to be able to remove the > cleanup in gdb_xml_parser::start_element, the gdb_xml_parser structure > is made to own the value with a gdb::unique_xmalloc_ptr. > > This patch has been tested on the buildbot. I pushed this one in. Simon