From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23648 invoked by alias); 29 Sep 2017 10:21:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23025 invoked by uid 89); 29 Sep 2017 10:21:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 29 Sep 2017 10:21:11 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A3C1481DEF; Fri, 29 Sep 2017 10:21:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A3C1481DEF Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id E2CB886E95; Fri, 29 Sep 2017 10:21:09 +0000 (UTC) Subject: Re: [RFA 02/11] Remove cleanups from mi_cmd_break_insert_1 To: Tom Tromey References: <20170912185736.20436-1-tom@tromey.com> <20170912185736.20436-3-tom@tromey.com> <294ad0fc-6500-2871-42c7-b0414dbdf563@redhat.com> <87mv5ewadz.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <61bf3379-61f6-e6f6-4148-a60928cb445b@redhat.com> Date: Fri, 29 Sep 2017 10:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <87mv5ewadz.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00898.txt.bz2 On 09/29/2017 02:39 AM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> IMO, it'd be even better to build the std::string directly > Pedro> instead of building an obstack and then dupping the string. > > Here's the new patch. OK, please push. Thanks for doing this. Thanks, Pedro Alves