From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id bEPkLabF0GZvKBkAWB0awg (envelope-from ) for ; Thu, 29 Aug 2024 15:01:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1724958118; bh=avG9MR+pX3mO6Ce706kHWafVodpfybkImRboWDcdAAI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JVqizQLjZ0jxe3pCEu2EXX7BT0blRj4LAgzVWlmOAy1ypCJqWztKNeQdbRNkC16a5 FkX1dhtsyBQ9CG9/KYpaN/BfgJbLOVV5Lk+OgTGxWMNNz4UNIkU4wZt867Qou11qNC lAmrwRtTREROCJuQMR5JEROjZQ/egMkwfEbfDF4o= Received: by simark.ca (Postfix, from userid 112) id A4E511E0D0; Thu, 29 Aug 2024 15:01:58 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=G46TO6Js; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 759911E030 for ; Thu, 29 Aug 2024 15:01:56 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 163ED3861029 for ; Thu, 29 Aug 2024 19:01:56 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 2782C385DDD2 for ; Thu, 29 Aug 2024 19:01:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2782C385DDD2 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2782C385DDD2 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724958096; cv=none; b=cYiI3NePCcybsbfjobLWWrbh3fhWK0Ljj4Xi0ppg6DfO2cNEVQG2MQM3bUFNqblCqnJ8O0D+Vl5aQxpjnPBVYwZVc7t5g+D3np7nOHN3sqcGBCzSNE2sZBv9yAVmYCvUiN4OUkWS5YCzOCwFHgGNjy8qgDQEZYH8ohCg5KQdEDY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724958096; c=relaxed/simple; bh=avG9MR+pX3mO6Ce706kHWafVodpfybkImRboWDcdAAI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=learIqgytrYqw7YNq+sbYUkw2Ax3md0iK6Lng6sXnOewx0X15fW6cjbgVNse7yZ8AHQtU514blqHG0KJLf0D4Rdc1Xf8HP/7YmSO/tAgHTVdysXxmXOKnErfWBqWOFdatmONxP16xzQUkCC4MmNxGu2f93LO0nKfMLUsdjw0m/M= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1724958093; bh=avG9MR+pX3mO6Ce706kHWafVodpfybkImRboWDcdAAI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=G46TO6Jsj2iblP0vtx77CPJ/AnNscKJTf1nqLuUzWYVhbilha0NSa6KnCMqrK+uSL lftrpCmDOy6iYcQblS546Mz+/H6s8aO1PIJ2oTjBdWLInz1hRKLk+ZCBg/WaLGuwt8 ywIaglesM97ethEUQJfAC7xDNXXjL9wA7a1QPt8c= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 313D41E030; Thu, 29 Aug 2024 15:01:32 -0400 (EDT) Message-ID: <61b747ca-adfe-4d06-b36e-5b4d38a769e2@simark.ca> Date: Thu, 29 Aug 2024 15:01:32 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: reject inserting breakpoints between functions To: Simon Marchi , "Gerlicher, Klaus" , Andrew Burgess Cc: "Simon.Marchi@amd.com" , "gdb-patches@sourceware.org" References: <20220408200536.235329-1-simon.marchi@efficios.com> <6630b03f.050a0220.6a68d.6289SMTPIN_ADDED_BROKEN@mx.google.com> <87ttjhoocc.fsf@redhat.com> Content-Language: en-US From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2024-08-12 10:54, Simon Marchi wrote: > On 8/7/24 4:27 AM, Gerlicher, Klaus wrote: >> Hi Simon, >> >> Kindly reminding again about your breakpoint sliding patch. >> >> I worked a bit with it, I have had one additional issue that would be fixed with below patch but of course since your original patch hasn't landed yet I can't post this as a real patch. >> >> So if you want to integrate this to your patch or treat this in another way, please let me know. >> >> Thanks >> Klaus > > Thanks for reminding me... I'll try to come back to this this week. > > Simon I went ahead and pushed Andrew's version of my patch, with one small change, to use a reference instead of a pointer. Klaus, can you rebase and re-post your patch? Simon