From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KAKvA2YHQGBxYgAAWB0awg (envelope-from ) for ; Wed, 03 Mar 2021 17:02:14 -0500 Received: by simark.ca (Postfix, from userid 112) id 0D4BD1EF78; Wed, 3 Mar 2021 17:02:14 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 629E81E54D for ; Wed, 3 Mar 2021 17:02:13 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C777A3857832; Wed, 3 Mar 2021 22:02:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C777A3857832 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1614808930; bh=O9ZTcxQnor0R/Xvw7zG0wP8Ccpgy+h9+c4Pq7gWrq9w=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=A6nHzTWFzdsQuJ/EVGYwmzdfYO7rj9g5/gSAQ3Vvpgyf8aNpQwpfuvr9KffGBhRBt kTJFrob2Pi7Be1FycY4Ti804h9fd9LQTuE0yi5fSu4OJUvlWPcnldIEn4hKMBqZdeZ eHnMi7QvBH9u8nUODDg1MBzUbotzxZqSuqGJnBcQ= Received: from aserp2130.oracle.com (aserp2130.oracle.com [141.146.126.79]) by sourceware.org (Postfix) with ESMTPS id 3A35C3857832 for ; Wed, 3 Mar 2021 22:01:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3A35C3857832 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 123LtLg3065286; Wed, 3 Mar 2021 22:01:58 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2130.oracle.com with ESMTP id 36ybkbd7u5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 Mar 2021 22:01:58 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 123Luc2I189561; Wed, 3 Mar 2021 22:01:57 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 36yyuu1eyf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 Mar 2021 22:01:57 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 123M1uPA014993; Wed, 3 Mar 2021 22:01:56 GMT Received: from [10.159.251.190] (/10.159.251.190) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 03 Mar 2021 22:01:56 +0000 Subject: Re: [PATCH,V2 3/5] CTF: handle forward reference type To: Tom Tromey , Weimin Pan via Gdb-patches References: <1614650018-9135-1-git-send-email-weimin.pan@oracle.com> <1614650018-9135-2-git-send-email-weimin.pan@oracle.com> <1614650018-9135-3-git-send-email-weimin.pan@oracle.com> <1614650018-9135-4-git-send-email-weimin.pan@oracle.com> <87wnuox8s2.fsf@tromey.com> Message-ID: <61783d94-0068-305b-cfb5-b776bc29113e@oracle.com> Date: Wed, 3 Mar 2021 14:01:55 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <87wnuox8s2.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9912 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103030155 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9912 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 impostorscore=0 suspectscore=0 phishscore=0 bulkscore=0 mlxscore=0 lowpriorityscore=0 clxscore=1015 mlxlogscore=999 adultscore=0 malwarescore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103030155 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Wei-min Pan via Gdb-patches Reply-To: Wei-min Pan Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 3/3/2021 12:49 PM, Tom Tromey wrote: >>>>>> ">" == Weimin Pan via Gdb-patches writes: >>> Added function fetch_tid_type which calls get_tid_type and will set up >>> the type, associated with a tid, if it is not read in yet. Also implement >>> function read_forward_type which handles the CTF_K_FORWARD kind. > Are forward types always filled in? > Or are they incomplete types (like in C)? No, these types are not always filled in and can be incomplete. > >>> + TYPE_LENGTH (type) = 0; >>> + type->set_is_stub (true); > I ask because I think you'd only want to do this for incomplete types. > > Tom