Re: [PATCH 1/6] gdb/infcmd: remove the unused parameter 'args' in 'attach_post_wait'

Simon Marchi via Gdb-patches
2021-04-21T19:32:17Z

On 2021-04-21 3:24 p.m., Tom Tromey wrote:
>>>>>> ">" == Tankut Baris Aktemur via Gdb-patches <gdb-patches@sourceware.org> writes:
>
>>> gdb/ChangeLog:
>>> 2021-04-21 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
>
>>> * infcmd.c (attach_post_wait): Remove the unused parameter 'args'.
>>> Update the references below.
>>> (struct attach_command_continuation_args)
>>> (attach_command_continuation)
>>> (attach_command_continuation_free_args)
>>> (attach_command)
>>> (notice_new_inferior): Update to remove the reference to 'args'.
>
> Normally it's good to have some text in the body that explains the
> commit.

I agree with you in general, but when I do patches like this one (remove
unused parameter / variable), I also find it hard to find anything else
to say than just repeating the subject.

Simon