From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33153 invoked by alias); 9 Nov 2016 14:48:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32895 invoked by uid 89); 9 Nov 2016 14:48:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=2045 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Nov 2016 14:48:48 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9397D61B83; Wed, 9 Nov 2016 14:48:47 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uA9EmkEt012979; Wed, 9 Nov 2016 09:48:46 -0500 Subject: Re: [PATCH v2 5/5] Stash frame id of current frame before stashing frame id for previous frame To: Kevin Buettner , gdb-patches@sourceware.org References: <20161102151111.2462c806@pinnacle.lan> <20161102152601.6e79f698@pinnacle.lan> From: Pedro Alves Message-ID: <61313629-93ad-933c-c699-6919d90a9d80@redhat.com> Date: Wed, 09 Nov 2016 14:48:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20161102152601.6e79f698@pinnacle.lan> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00217.txt.bz2 On 11/02/2016 10:26 PM, Kevin Buettner wrote: > I will first note that the frame id for frame has not been computed yet. (This > was verified by placing a breakpoint on compute_frame_id().) > > The call to get_prev_frame() causes the the frame id to (eventually) be > computed for the previous frame. Here's a backtrace showing how we > get there: > > at gdb/frame.c:496 > at gdb/frame.c:1871 > at gdb/frame.c:2045 > at gdb/frame.c:2061 > at gdb/frame.c:2303 > at gdb/python/py-frame.c:381 Function names would make that backtrace soooo much easier to read. :-) > gdb/ChangeLog: > > * frame.c (get_prev_frame): Stash frame id for current frame > prior to computing frame id for previous frame. I'm fine with this solution. LGTM. Thanks, Pedro Alves