From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id okS9NtREwmbLtgsAWB0awg (envelope-from ) for ; Sun, 18 Aug 2024 15:00:36 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=oBMFCCUP; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HHfiMXX2; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=gX4gKmaW; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=z327OLQo; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C43BC1E0D0; Sun, 18 Aug 2024 15:00:36 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8A6DC1E08C for ; Sun, 18 Aug 2024 15:00:34 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2529F385021C for ; Sun, 18 Aug 2024 19:00:34 +0000 (GMT) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 109F63858429 for ; Sun, 18 Aug 2024 19:00:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 109F63858429 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 109F63858429 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724007615; cv=none; b=ApRjYTMwmQfb45di1BZyxZnN+auN4X0gHM8bJ/XalvMwIgsTs80ia0aDgM1n5mcsfg1M0rItH9Djy8K1nF5TTPk0uzBKGL9mGbdZbIpyyAjHXtVBNpVsmSOQjoe8OsGGKHtMWHSZBfqZhfG1HcJVsA5lAIBGJRE/pj5GWzsGJIQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724007615; c=relaxed/simple; bh=IdYdmo2qL+fwA2fJb6sKfBOj0gYmoKyKWEPkRFvmeiY=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=NU4YNyUv5dHrb/dAKMXAnycjY9c9aWmk54/qQHLrU8acDI2Ba98yb6ILC1/GnKXHowcRlnrOvECgB5cKk8Abox1b9MmnR4VEU65BTehtIUNWNAHG/A2iYDcRqKxthRd/KUnvjFd+OZ3+eeeHNh+GojrJaHNoGaZD2ZqzD8N2pVo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E922A1F7A2; Sun, 18 Aug 2024 19:00:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1724007612; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dky1ouGw2+uPL3rU8wmP7Nd5IamxN29yDpKGPYMjhB0=; b=oBMFCCUPyzn+H9OKdufTeD9TmslrtvyO1GCcIbPD/gz48GB8d9djGlGKLkxBxkiRCEeI5D JV3zNmsB+LY+CFCRYk4rvd/m9EBjgEnHvYGu4ISY3HRD2OvnwzNU63GrcLNS40LxzLuIME LbXFnlGKxwFOjQoPA24VRVyVX9cJw/Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1724007612; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dky1ouGw2+uPL3rU8wmP7Nd5IamxN29yDpKGPYMjhB0=; b=HHfiMXX28EU28TFfdvZKpThVaVypjrW944Mdf1/B+eYIiT8uY9E/ohURelc8dBj++Z0ikL N5zjGIPq8MSd07DQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1724007611; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dky1ouGw2+uPL3rU8wmP7Nd5IamxN29yDpKGPYMjhB0=; b=gX4gKmaWfpkFaDb9jO6UctPrvOWiZTra7Mn8vnYMicLaOx4+Xnm1MeUa4GojT6Gv1a+gcO KtkFiWKOV22Ywit7liECkt2uNKFKtmNOm3Z1GJyaUCXTgu+7RWFvjjPSxdTvxU6SD94o7u qu15elsaKbcbgbzYdC0fksr34YJ8O6A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1724007611; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dky1ouGw2+uPL3rU8wmP7Nd5IamxN29yDpKGPYMjhB0=; b=z327OLQor4nsp2tSsYW0dPH8RpgeI6hR2eCHu8rq9RKfaNwoiIWgpAJ6vbKaieBHP2H6GG quPiNxUBs1t7J3Dw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C788D1397F; Sun, 18 Aug 2024 19:00:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Kx9pL7tEwmbMVgAAD6G6ig (envelope-from ); Sun, 18 Aug 2024 19:00:11 +0000 Message-ID: <611d09da-0a42-4915-8c67-37166aa743d4@suse.de> Date: Sun, 18 Aug 2024 21:00:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] [gdb] Prune inferior after switching inferior To: Kevin Buettner Cc: gdb-patches@sourceware.org References: <20240731074605.12070-1-tdevries@suse.de> <20240818114356.459b48f9@f40-zbm-amd> Content-Language: en-US From: Tom de Vries In-Reply-To: <20240818114356.459b48f9@f40-zbm-amd> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, suse.de:mid, suse.de:email] X-Spam-Level: X-Spam-Score: -4.30 X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/18/24 20:43, Kevin Buettner wrote: > On Wed, 31 Jul 2024 09:46:05 +0200 > Tom de Vries wrote: > >> Usually with test-case gdb.python/py-progspace-events.exp I get: >> ... >> (gdb) inferior 1^M >> [Switching to inferior 1 [process 4116] (py-progspace-events)]^M >> [Switching to thread 1.1 (Thread 0xf77d0ce0 (LWP 4116))]^M >> 28 { /* Nothing. */ }^M >> (gdb) PASS: gdb.python/py-progspace-events.exp: inferior 1 >> step^M >> FreeProgspaceEvent: ^M >> do_parent_stuff () at py-progspace-events.c:41^M >> 41 ++global_var;^M >> (gdb) PASS: gdb.python/py-progspace-events.exp: step >> ... >> >> But occasionally I run into the following FAIL: >> ... >> (gdb) inferior 1^M >> [Switching to inferior 1 [process 5199] (py-progspace-events)]^M >> [Switching to thread 1.1 (Thread 0xf77d0ce0 (LWP 5199))]^M >> 28 { /* Nothing. */ }^M >> (gdb) FreeProgspaceEvent: ^M >> FAIL: gdb.python/py-progspace-events.exp: inferior 1 (timeout) >> ... >> >> This is caused by a race between the handling of an event, and the >> "inferior 1" command. >> >> In the passing case, the event is handled first. During which prune_inferiors >> is called, but it can't remove inferior 2, because it's still the current one. >> >> In the failing case, the "inferior 1" command is handled first. Then during >> handling of the event, prune_inferiors is called, and it can remove inferior 2 >> because it's no longer the current one. >> >> This looks like a test-case issue to me, but ISTM that we can do better: by >> calling prune_inferiors asap, at the end of the "inferior 1" command, we >> stabilize the moment when the inferior is removed: >> ... >> (gdb) inferior 1^M >> [Switching to inferior 1 [process 5199] (py-progspace-events)]^M >> [Switching to thread 1.1 (Thread 0xf77d0ce0 (LWP 5199))]^M >> 28 { /* Nothing. */ }^M >> FreeProgspaceEvent: ^M >> (gdb) PASS: gdb.python/py-progspace-events.exp: inferior 1 >> ... >> >> This also allows us to simplify the test-case by removing the step command, >> which is no longer required to trigger the pruning of the inferior. >> >> Tested on x86_64-linux. >> >> PR gdb/31440 >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31440 > > Approved-by: Kevin Buettner > Hi Kevin, thanks for the review, pushed. - Tom