From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96961 invoked by alias); 4 Apr 2017 18:44:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96864 invoked by uid 89); 4 Apr 2017 18:44:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=Hx-languages-length:529, tiny X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Apr 2017 18:44:14 +0000 Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id F230210A87D; Tue, 4 Apr 2017 14:44:13 -0400 (EDT) From: John Baldwin To: gdb-patches@sourceware.org Cc: Pedro Alves Subject: Re: [PATCH 17/18] -Wwrite-strings: The Rest Date: Tue, 04 Apr 2017 18:44:00 -0000 Message-ID: <6118858.lO2ajWnfox@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-STABLE; KDE/4.14.10; amd64; ; ) In-Reply-To: <1491326751-16180-18-git-send-email-palves@redhat.com> References: <1491326751-16180-1-git-send-email-palves@redhat.com> <1491326751-16180-18-git-send-email-palves@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00056.txt.bz2 On Tuesday, April 04, 2017 06:25:50 PM Pedro Alves wrote: > This is the remainder boring constification that all looks more of less > borderline obvious IMO. > > gdb/ChangeLog: > yyyy-mm-dd Pedro Alves > > * fbsd-tdep.c (fbsd_core_pid_to_str): Constify. Tiny nit: this isn't actually changed in this patchset (was going to quickly eyeball it). Perhaps the changelog is stale from you breaking the pid_to_str target method out into its own patch? -- John Baldwin