From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 1CDFB388C011 for ; Mon, 29 Jun 2020 14:31:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1CDFB388C011 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1C67CACF0; Mon, 29 Jun 2020 14:31:47 +0000 (UTC) Subject: [PATCH][gdb/testsuite] Handle early_flags in gdb_default_target_compile To: Luis Machado , gdb-patches@sourceware.org References: <20200619120959.GA10641@delia> From: Tom de Vries Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: <6100c6f4-dfc9-26d1-c053-a9bd2995c1be@suse.de> Date: Mon, 29 Jun 2020 16:31:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------755E7157386A6534DB29CDE8" Content-Language: en-US X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, BODY_8BITS, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jun 2020 14:31:49 -0000 This is a multi-part message in MIME format. --------------755E7157386A6534DB29CDE8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit [ was: Re: [PATCH][gdb/testsuite] Limit default_target_compile override ] On 6/22/20 11:34 PM, Luis Machado wrote: > Hi, > > This commit seems to have caused a few regressions for aarch64-linux: > > -# of expected passes        75098 > -# of unexpected failures    63 > -# of expected failures        114 > +# of expected passes        75036 > +# of unexpected failures    149 > +# of expected failures        111 > > They are distributed across a few different tests: > > gdb.base/display.exp > gdb.base/jit-reader-simple.exp > gdb.base/shlib-call.exp > gdb.base/solib-weak.exp > gdb.base/step-test.exp > gdb.base/store.exp > gdb.base/type-opaque.exp > gdb.cp/ovldbreak.exp > gdb.multi/multi-target.exp > gdb.reverse/step-precsave.exp > gdb.reverse/step-reverse.exp > > It seems mostly related to missing options in the compilation line. For > example, display.exp is missing -fno-stack-protector, which leads to a > different source stepping pattern than the test is actually expecting. > Hi Luis, thanks for reporting this. This should be fixed by attached patch. Any comments? Thanks, - Tom --------------755E7157386A6534DB29CDE8 Content-Type: text/x-patch; charset=UTF-8; name="0001-gdb-testsuite-Handle-early_flags-in-gdb_default_target_compile.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename*0="0001-gdb-testsuite-Handle-early_flags-in-gdb_default_target_"; filename*1="compile.patch" [gdb/testsuite] Handle early_flags in gdb_default_target_compile In gdb_default_target_compile, we use dejagnu's default_target_compile, unless we need support for languages that are not yet support in the used dejagnu version, in which case we use a local default_target_compile: gdb_default_target_compile_1. However, there's another reason to use the local default_target_compile: when early_flags is used, because there's no dejagnu release available yet supporting this. Fix this by detecting and handling early_flags in gdb_default_target_compile. Tested on x86_64-linux. gdb/testsuite/ChangeLog: 2020-06-29 Tom de Vries PR testsuite/26175 * lib/future.exp (gdb_default_target_compile): Detect and handle early_flags. --- gdb/testsuite/lib/future.exp | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/gdb/testsuite/lib/future.exp b/gdb/testsuite/lib/future.exp index ba00a31c19..1aabbe3233 100644 --- a/gdb/testsuite/lib/future.exp +++ b/gdb/testsuite/lib/future.exp @@ -634,25 +634,28 @@ proc gdb_default_target_compile_1 {source destfile type options} { proc gdb_default_target_compile {source destfile type options} { global use_gdb_compile - set need_local 0 + set need_local_lang 0 + set need_local_early_flags 0 foreach i $options { if { $i == "ada" || $i == "d" || $i == "go" || $i == "rust" } { - set need_local [info exists use_gdb_compile($i)] - break + set need_local_lang [info exists use_gdb_compile($i)] } if { $i == "c++" } { - break + set need_local_lang 0 } if { $i == "f77" || $i == "f90" } { - set need_local [info exists use_gdb_compile(fortran)] - break + set need_local_lang [info exists use_gdb_compile(fortran)] + } + + if { [regexp "^early_flags=" $i] } { + set need_local_early_flags 1 } } - if { $need_local } { + if { $need_local_lang || $need_local_early_flags } { return [gdb_default_target_compile_1 $source $destfile $type $options] } --------------755E7157386A6534DB29CDE8--