Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: Klaus Gerlicher <klaus.gerlicher@intel.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 1/1] gdb/testsuite: require AVX in gdb.arch/amd64-frameptr-vecreg-unwind.exp
Date: Sat, 10 Oct 2026 13:43:20 -0700	[thread overview]
Message-ID: <60b852d8-05c1-4c18-b689-88e6bf7a6052@redhat.com> (raw)
In-Reply-To: <20261010085952.44761-1-klaus.gerlicher@intel.com>



On 10/10/26 1:59 AM, Klaus Gerlicher wrote:
> The test runs vxorps, so it fails with SIGILL on a CPU without AVX.
> Require have_avx.
> ---
>  gdb/testsuite/gdb.arch/amd64-frameptr-vecreg-unwind.exp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gdb/testsuite/gdb.arch/amd64-frameptr-vecreg-unwind.exp b/gdb/testsuite/gdb.arch/amd64-frameptr-vecreg-unwind.exp
> index 9e358c01642..83686948f8a 100644
> --- a/gdb/testsuite/gdb.arch/amd64-frameptr-vecreg-unwind.exp
> +++ b/gdb/testsuite/gdb.arch/amd64-frameptr-vecreg-unwind.exp
> @@ -20,7 +20,7 @@
>  # can read both rbx and ebx correctly for each frame, and that when we write to
>  # ebx, rbx for that frame is correctly updated.
>  
> -require is_x86_64_m64_target
> +require is_x86_64_m64_target have_avx
>  
>  standard_testfile
>  

LGTM.

Approved-by: Kevin Buettner <kevinb@redhat.com>


  reply	other threads:[~2026-10-10 23:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-10  8:59 Klaus Gerlicher
2026-10-10 20:43 ` Kevin Buettner [this message]
2026-10-11 16:07   ` Gerlicher, Klaus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60b852d8-05c1-4c18-b689-88e6bf7a6052@redhat.com \
    --to=kevinb@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=klaus.gerlicher@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox