From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47572 invoked by alias); 26 Nov 2016 16:47:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47562 invoked by uid 89); 26 Nov 2016 16:47:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=HX-PHP-Originating-Script:rcube.php, stood, table.body_flag, UD:table.body_flag X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 26 Nov 2016 16:47:52 +0000 Received: by simark.ca (Postfix, from userid 33) id 300071E86E; Sat, 26 Nov 2016 11:47:51 -0500 (EST) To: Pedro Alves Subject: Re: [PATCH 18/22] ui_out_table: Replace boolean flag with enum X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 26 Nov 2016 16:47:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org In-Reply-To: References: <20161124152428.24725-1-simon.marchi@polymtl.ca> <20161124152710.25007-18-simon.marchi@polymtl.ca> Message-ID: <60a2d96b57c23614647389c4b54af2fa@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.2 X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00897.txt.bz2 On 2016-11-24 13:42, Pedro Alves wrote: > On 11/24/2016 03:27 PM, Simon Marchi wrote: >> This patch is just a little cleanup, it replaces the body_flag field >> of >> ui_out_table with an enum. It expresses more explicitly the >> intent of the field (check that state == TABLE_STATE_HEADERS conveys >> more what we want to do than checking for !body_flag). > > Yay for avoiding the boolean trap. > > >> @@ -271,7 +279,7 @@ ui_out_table_begin (struct ui_out *uiout, int >> nbrofcols, >> previous table_end.")); >> >> uiout->table.flag = 1; >> - uiout->table.body_flag = 0; >> + uiout->table.state = ui_out_table_state::TABLE_STATE_HEADERS; > > Nit: This one stood out, as none of the other places fully qualify > the enum. > > You could also consider moving the enum to within > the table class, and/and use "enum class" to shorten the > names, if you want to scope it. TIL about "enum class". In patch "Class-ify ui_out_table", I move it to the ui_out_table class. If that's ok with you, I'll look into making use of enum class in that patch. I'll remove the "ui_out_table_state::" in this instance for consistency.