From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8315 invoked by alias); 1 Jan 2020 21:00:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8176 invoked by uid 89); 1 Jan 2020 21:00:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.5 required=5.0 tests=AWL,BAYES_05,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=folgendes, H*x:WebService, H*x:Mozilla, H*M:yahoo X-HELO: sonic304-23.consmr.mail.ir2.yahoo.com Received: from sonic304-23.consmr.mail.ir2.yahoo.com (HELO sonic304-23.consmr.mail.ir2.yahoo.com) (77.238.179.148) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 01 Jan 2020 21:00:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1577912399; bh=uEeBpGn3jPnjg4LmG6JFILs0AHOZEWUZu6QWm28nZPY=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject; b=Htgw2+AFYlD37DdlHxRqc3mLGvA0EquK/8dJ4yY2wDwL79/2KAf7ziiNsjwVmo7495SmdOGrsCCVExIzrPmTiOihdNhuCOIsl1XeihPyol1RyRYqyjrAik54jSinTRs2Z2uClHZNcfb+XCqivceqjdr/buxW4W5407s3bBNiMB1RmpJFojhjPXF3GIwRK/fMD9TojFfU0zMzox04EDnE0CYj+I2eTRWURRi2KCGP32mV7Qzdyewl4BEhBslfxV4++J+khnE3YN543rl4uJ87XwZa7+kaago7Vf4X5YeePKsUvoR/g787zSsn0YZ3tlb1wB1FEgnmlm07Bk5V/hSiFg== Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ir2.yahoo.com with HTTP; Wed, 1 Jan 2020 20:59:59 +0000 Date: Wed, 01 Jan 2020 21:00:00 -0000 From: "Hannes Domani via gdb-patches" Reply-To: Hannes Domani To: Gdb-patches Message-ID: <608464624.8876605.1577912394438@mail.yahoo.com> In-Reply-To: References: <20191231184222.34267-1-ssbssa.ref@yahoo.de> <20191231184222.34267-1-ssbssa@yahoo.de> <64c719e2-df88-6cd8-3f5b-246f0f7b7d58@simark.ca> <1134374112.8470290.1577819135686@mail.yahoo.com> Subject: Re: [PATCH v2] Fix install-strip for cross-compilation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00016.txt.bz2 Am Dienstag, 31. Dezember 2019, 21:12:21 MEZ hat Simon Marchi Folgendes geschrieben: > On 2019-12-31 2:05 p.m., Hannes Domani via gdb-patches wrote: > >=C2=A0 Am Dienstag, 31. Dezember 2019, 19:50:47 MEZ hat Simon Marchi Folgendes geschrieben: > > > >> On 2019-12-31 1:42 p.m., Hannes Domani via gdb-patches wrote: > >> > >>> The variable INSTALL_PROGRAM_ENV sets up STRIPPROG for the cross-comp= iler. > >>> > >>> If this is not done, the host 'strip' is used, and fails: > >>> > >>> /bin/sh /c/src/repos/binutils-gdb.git/install-sh -c -s gdb.exe \ > >>>=C2=A0=C2=A0 /gdb/gdb64-git/bin/$transformed_name.exe > >>> strip.exe:C:/gdb/gdb64-git/bin/_inst.33599_: file format not recogniz= ed > >>> > >>> With this change, it's fine: > >>> > >>> STRIPPROG=3D'x86_64-w64-mingw32-strip' \ > >>>=C2=A0=C2=A0 /bin/sh /c/src/repos/binutils-gdb.git/install-sh -c -s gd= b.exe \ > >>>=C2=A0=C2=A0 /gdb/gdb64-git/bin/$transformed_name.exe > >> > >> > >> Thanks for updating the change log, this LGTM.=C2=A0 I believe you don= 't have write access > >> to the repo, is that right?=C2=A0 Would you like me to push the patch = on your behalf, or > >> would you like to get a write access (useful if you plan on sending pa= tches regularly)? > > > > Yes, I don't have write access, and I do plan to send more patches in t= he future. > > > > With write access, is there more to it than just push the patch? > > Ok, if you do not yet have a Sourceware account, please fill this form to= get one: > > https://sourceware.org/cgi-bin/pdw/ps_form.cgi > > You can mention me as your sponsor.=C2=A0 If you already have an account,= you need to contact > the Sourceware overseers mailing list so they can adjust the permissions = to give you write > access to binutils-gdb. > > To push a patch, it's indeed just a matter of pushing the git commit.=C2= =A0 However, you need > to insert the ChangeLog entries in the actual ChangeLog files and amend y= our commit before > pushing.=C2=A0 Also, it's good to triple check that there is only what yo= u intend to push in the > branch you are about to push. > > Once you have write access, you can add yourself to the MAINTAINERS file,= in the "write after > approval" section and then send a "FYI" patch to this list, that gives yo= u a chance to practice. > > I won't push this patch, I'll let you do it once you have your account. > > Also, I see that you already have a copyright assignment files with the F= SF, that's perfect. I've now added myself to the MAINTAINERS file, and committed this patch. Regards Hannes Domani