From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73822 invoked by alias); 15 Jan 2016 20:23:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72958 invoked by uid 89); 15 Jan 2016 20:23:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.2 required=5.0 tests=AWL,BAYES_40,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=get_ptrace_pid, openbsd, OpenBSD, HX-Greylist:SMTP X-HELO: bigwig.baldwin.cx Received: from bigwig.baldwin.cx (HELO bigwig.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Fri, 15 Jan 2016 20:23:09 +0000 Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 1A6FFB958; Fri, 15 Jan 2016 15:23:06 -0500 (EST) From: John Baldwin To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 4/6] Use LWP IDs with ptrace register requests on FreeBSD. Date: Fri, 15 Jan 2016 20:23:00 -0000 Message-ID: <6071650.bM8jrAlx9r@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <5697B9B0.1090705@redhat.com> References: <1452721551-657-1-git-send-email-jhb@FreeBSD.org> <1452721551-657-5-git-send-email-jhb@FreeBSD.org> <5697B9B0.1090705@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00329.txt.bz2 On Thursday, January 14, 2016 03:07:28 PM Pedro Alves wrote: > [Dropping binutils.] > > On 01/13/2016 09:45 PM, John Baldwin wrote: > > This allows gdb to fetch per-thread registers for multi-threaded FreeBSD > > processes. NetBSD and OpenBSD also accept LWP IDs for ptrace requests > > to fetch per-thread state. > > I'd prefer to make inf-ptrace.c:get_ptrace_pid extern and use > it, instead of duplicating it multiple times. This sounds good to me. Do you want me to use it in other places as well? sparc-nat.c at least duplicates the same logic inline. amd64linux-nat.c does as well. If so, would you rather that be a seperate patch (expose get_ptrace_pid() and use it in existing targets) from this patch? -- John Baldwin