Re: [PATCH] gdb: fix "frame function" issue when call is last instruction

[Sahil <icegambit91@gmail.com>]

Hi,

On Sunday, June 30, 2024 7:38:08 PM GMT+5:30 Sahil Siddiq wrote:
> Currently, the "frame function" fails when the last
> instruction is a call. In such a case, the $rip
> register points to an address that lies outside the
> frame.
> 
> Using "get_frame_address_in_block" instead of
> "get_frame_pc" resolves this issue.
> 
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30929
> ---
> Hi,
> 
> This is my first time contributing to gdb. I have
> tried to adhere to the styling convention. Please
> let me know if I have missed something.
> 
> Instead of extending the existing frame-selection.exp
> test, I thought I would create a new test since the C
> file is new and it seemed like the implementation of
> the test isn't similar enough to be kept in the existing
> exp file. Please let me know if this is undesirable.
> 
> Thanks,
> Sahil
> 
>  gdb/stack.c                                   |   4 +-
>  .../frame-selection-last-instr-call.c         |  28 ++++
>  .../frame-selection-last-instr-call.exp       | 139 ++++++++++++++++++
>  3 files changed, 169 insertions(+), 2 deletions(-)
>  create mode 100644 gdb/testsuite/gdb.base/frame-selection-last-instr-call.c
> create mode 100644
> gdb/testsuite/gdb.base/frame-selection-last-instr-call.exp
> [...]

I noticed that the test introduced in this patch fails in some environments. See
for example:
1. regressions on arm [1]
2. regressions on aarch64 [2]

I have submitted a new patch where the test should run successfully regardless
of the build environment.

Thanks,
Sahil

[1] https://ci.linaro.org/job/tcwg_gdb_check--master-arm-precommit/2800/
[2] https://ci.linaro.org/job/tcwg_gdb_check--master-aarch64-precommit/2814/