From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) by sourceware.org (Postfix) with ESMTPS id 0EFB5395B083 for ; Tue, 12 May 2020 16:21:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0EFB5395B083 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id B22D52400FC for ; Tue, 12 May 2020 18:20:58 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 49M32L1z3gz9rxr; Tue, 12 May 2020 18:20:58 +0200 (CEST) Subject: Re: [PATCH 4/4] [PR gdbserver/25893]: Add gdbserver test for argument with space in it To: Simon Marchi , gdb-patches@sourceware.org References: <20200429111638.1327262-1-m.weghorn@posteo.de> <20200429111638.1327262-6-m.weghorn@posteo.de> <1190e73a-8f10-dc6d-4d59-b9a2929530ad@simark.ca> <8839910b-7018-78b7-a46b-7b2bfcb6d2ef@simark.ca> From: Michael Weghorn Message-ID: <606608d5-4011-88ef-2d15-f23c04a10810@posteo.de> Date: Tue, 12 May 2020 18:20:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 May 2020 16:21:02 -0000 On 11/05/2020 17.04, Simon Marchi wrote: > On 2020-05-11 10:33 a.m., Michael Weghorn wrote: >> These don't work yet with the last patch series. I'll recheck once I >> have finished updating the patch series and in particular fixed the >> segfault you mentioned earlier. >> >> I hope to be able to send an updated patch series tomorrow. >> >> Do I understand correctly that I can just drop my patch adding the test, >> since this is now already covered in a better way by the test case added >> in your second patch? > > I think so. You can insert my two patches in your series, as the test depends > on the fix. > > If you haven't found already: after running the `make check` commands, the > transcript is found in testsuite/gdb.log. Thanks a lot, in particular also for your previous explanations of how those things work together and how to run the various configurations. Those really helped in finding out what was going wrong. The problem was that 'handle_v_run' in 'gdbserver/server.cc' already had some special handling for empty args, passing them as "''" into the arg vector, and 'construct_inferior_arguments' then took this as a literal string, so the output of the empty argv[2] was "''" instead of "". I adapted this in the new version of that patch: https://sourceware.org/pipermail/gdb-patches/2020-May/168350.html All of make check TESTS="gdb.base/inferior-args.exp" RUNTESTFLAGS="--target_board=native-gdbserver" make check TESTS="gdb.base/inferior-args.exp" RUNTESTFLAGS="--target_board=unix" make check TESTS="gdb.base/inferior-args.exp" RUNTESTFLAGS="--target_board=native-extended-gdbserver" now pass for me on linux-amd64 (Debian testing) with the new patch set and your two commits on top. I did not explicitly add your commits in the patch series I sent, just applied them locally (since I was uncertain of how to properly handle the mismatch between you being the patch author and myself being the submitter/email sender). Michael