From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121115 invoked by alias); 23 Aug 2018 20:35:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 121096 invoked by uid 89); 23 Aug 2018 20:35:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=blame X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Aug 2018 20:35:32 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w7NKZQwA027111 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 23 Aug 2018 16:35:30 -0400 Received: by simark.ca (Postfix, from userid 112) id EE3B81EB37; Thu, 23 Aug 2018 16:35:25 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 748D21E52D; Thu, 23 Aug 2018 16:35:25 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 23 Aug 2018 20:35:00 -0000 From: Simon Marchi To: John Darrington Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] gdb: Added builtin types for 24 bit integers. In-Reply-To: <20180823200349.gxeuad3ms3c2apei@jocasta.intra> References: <20180823173526.26144-1-john@darrington.wattle.id.au> <7b7853c6462d8806bc4a2a743330a382@polymtl.ca> <20180823200349.gxeuad3ms3c2apei@jocasta.intra> Message-ID: <603c98bc68bec04acb84d809c838abb0@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00582.txt.bz2 On 2018-08-23 16:03, John Darrington wrote: > On Thu, Aug 23, 2018 at 03:41:11PM -0400, Simon Marchi wrote: > > Hi John, > > It's always useful to have a little commit message along with the > patch > to explain why this is needed. What's your problem and how does > it help > you solve it. Could you expand a bit on your patches? > > Thanks, > > Hi Simon, > > Sorry, I had presumed it was self evident from the final patch, which > adds support for the S12Z target - a 24 bit architecture. Well this is new information to me :). It is clear now, but somebody doing a git blame to know why 24-bit integer types were added would only find the patch that adds them by itself and wonder who uses that. A little message like This patch adds 24-bit integer types, used when debugging on the S12Z architecture (added by a later patch in this series). clears that up. That might looks a bit silly, but I think it helps in the long run. > It seems that up till now there has been no 24 bit targets, so the > other > two patches as some necessary things to make that possible. Thanks. Coming back to the code of the patch, I was wondering if these 24-bit types are useful or even relevant for any other architecture. Would it work if you only defined the types for s12z architectures, storing the reference in the gdbarch_tdep object? Simon