From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OR7vNnbzmWMmqAAAWB0awg (envelope-from ) for ; Wed, 14 Dec 2022 11:01:58 -0500 Received: by simark.ca (Postfix, from userid 112) id D68B91E126; Wed, 14 Dec 2022 11:01:58 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=WuhtvpvH; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E344F1E112 for ; Wed, 14 Dec 2022 11:01:57 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6F69D385516A for ; Wed, 14 Dec 2022 16:01:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6F69D385516A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1671033716; bh=24Hjkgn6ump8buRuq4za3yvuTPBwqVWTdxx9JnMs+fE=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=WuhtvpvHI+ekSmzEIX8AfhZTv0XZ8QEVDBuJu0NYoC4pT/I69f1PyYXR1yDvmaOf1 zkoh2n6K5nW/aZRTyiJp+XtmMMB5of/0VOiIfOZgXARpd4u6nKHaEo8FNrE1GSb/HE ilNhSGow+ChMQUCtjsstqgh9kXmahMCiTANTu9WI= Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id CDB33385B52F for ; Wed, 14 Dec 2022 16:01:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CDB33385B52F Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 369D91E112; Wed, 14 Dec 2022 11:01:03 -0500 (EST) Message-ID: <603b56b4-5983-832d-89ad-7e1f7669065c@simark.ca> Date: Wed, 14 Dec 2022 11:01:02 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] gdb: fix command lookup in execute_command () commands" Content-Language: en-US To: Tom Tromey , Jan Vrany via Gdb-patches Cc: Jan Vrany , luis.machado@arm.com References: <4dc13e01-2fd8-a63e-24f2-a1f7c7650d3b@simark.ca> <20221214110747.1150349-1-jan.vrany@labware.com> <87lenadlhr.fsf@tromey.com> In-Reply-To: <87lenadlhr.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 12/14/22 10:59, Tom Tromey wrote: > Simon> Here are the unexpected failures I saw: > > [...] > > Jan> Hmm. I do not see these failures. > > I applied the patch and ran the full test suite. I'm on x86-64 Fedora 34. > > I see two new FAILs but they are in thread tests and so I assume they > are just the usual kind of racy test thing. > > I didn't see any of the failures that Simon reports. > > So, from my perspective your proposed patch seems fine. I don't think > we need to back out the previous patch. > > Simon, could you maybe double-check your results somehow? Or pick one > of the failures and try to see why it's happening? > > thanks, > Tom Do you have ASan enabled in that build? Simon