From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 5RLgM5tvXWgwaCAAWB0awg (envelope-from ) for ; Thu, 26 Jun 2025 12:04:43 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=WnAIAnZD; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=WnAIAnZD; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BED6B1E11E; Thu, 26 Jun 2025 12:04:43 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 545F21E0C2 for ; Thu, 26 Jun 2025 12:04:42 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D67EC385C6D6 for ; Thu, 26 Jun 2025 16:04:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D67EC385C6D6 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=WnAIAnZD; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=WnAIAnZD Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazlp170130007.outbound.protection.outlook.com [IPv6:2a01:111:f403:c20f::7]) by sourceware.org (Postfix) with ESMTPS id 236A2385B51A for ; Thu, 26 Jun 2025 16:04:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 236A2385B51A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 236A2385B51A Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c20f::7 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1750953843; cv=pass; b=e2AuTBlGafVCvv9vWE1titOsYTrqoIo1HK0pNVf1nWxkPA9Gqe6NSP7fRiBRnZB8WQnDYYYjruKMr0kDPvWYn06t7LICZY1k1wphaHl3JKl4p+oxQXXJxbs+Yq095X1DxNPBniHxF36HBENImy7TlSongoduYcSw8qKDOUO0dO4= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1750953843; c=relaxed/simple; bh=wghSub62gVFkxMmfhx4xwKWrIcV3BCEm2aVv24gOl4o=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=aC1qKu5tYinqvZIBA6z0vxSbpmCMUFngl7cLfCgkAhblswE8oMNIrEKUTX5JBmfo3Y3fAeN+FdDPrJM3cYM+TdEA9+/sfYwAtWh85G+5lUSJx5/2cU5U8xnGEQeGIzWd6YneXGPmqhhl8ff3e5gUBRrKZSfYkdzdvja3QlLq2Hc= ARC-Authentication-Results: i=3; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 236A2385B51A ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=t8AkQbM6BA9foNOlxKOqd5qNQfDatB6eVz5LGAZBDF4KOCOWxtAF9PhBsW2btWK5e3xnwjzNzYCq1OJe484wEoJR8qD5LLYQD7Ke1TW0yIXVjSQvRdnyNkbg4uk0Oe7XoZKQw1bKKoKR8KunoNlyhhHK7IcwpTmLUcEGqxpp+CQ0iohDSRnR/BpBMtJhLXoJNiaesysfyYf/eKKHv7IYJUFoKZyupINYnLioUStbfwHxfec1+uTkrHYlRgXRXu3RfxR+Th8g1SnotqV8NAG8peJa4MxWbpTQ8hhRdPkvsZtKPEyArZdLx25NNObxz/HxDaxbmxubOAUuxVS9+/+ehg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T6GEQk9YJsATplAUZEKMH2KYN8lWSqiwfLzK5V3TfJY=; b=LYWdEZRIf+CD0ij/iCyVQMqd1W+U0tzuDYgX2OzX7zzTNT5EQPleTnO8HOTdgmdWSlRLro4o1w/bHPyZpirxVkoumdQMr3MPVa9QPO2LYLqluGqM/o0oYXl3DxeAI6oU2NSbc6TEQT+C8t4fyxfBInj5rCgCdF05QDipdZ/+9T/1njm7q7Hy5F1TU1eCVsh4FKFFzMbgdfAWBZvDGqhVvJCqnab0VjWK3yCJTugPAUZd7bw0IQAttZgPFP6J4hNPTglqjaEJzb5+UC5sOwEHF9bEU18o9NaGSA3XorkqmYM+LJJhydACRUO5+AahkChf7h98lwTUlCi7dZszmUX96A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=intel.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T6GEQk9YJsATplAUZEKMH2KYN8lWSqiwfLzK5V3TfJY=; b=WnAIAnZDYdpOksep34zt4pasmb78afRddKWPAUxAJavcCtx1CeKUTODwEUiNTxRC4lenSnva9/EaVqVS7mgaiiXqh9Hhur5kwe2AvB+h1ThtdMj9ON69cqntw6Cw3RWuY9W7cizCEC8vmB8nWAUPfjOQcimN0bnS6npd0MgnZR0= Received: from DUZPR01CA0015.eurprd01.prod.exchangelabs.com (2603:10a6:10:3c3::18) by GV2PR08MB8171.eurprd08.prod.outlook.com (2603:10a6:150:7b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.26; Thu, 26 Jun 2025 16:03:55 +0000 Received: from DB1PEPF000509F3.eurprd02.prod.outlook.com (2603:10a6:10:3c3:cafe::3c) by DUZPR01CA0015.outlook.office365.com (2603:10a6:10:3c3::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.17 via Frontend Transport; Thu, 26 Jun 2025 16:03:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by DB1PEPF000509F3.mail.protection.outlook.com (10.167.242.149) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Thu, 26 Jun 2025 16:03:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Aja9e5MWa+sbPmiN0tw9qY8+cidJAUepPZeolUA+P6WuCCelgOtG5cT1nqSLVpnE9qbzUpthnWQnZAvpjXWZQkGtliP6fNSL4GYgGRzwOR7aykjuputSzsG2Awq5/yGt4U/JoJphjk39E9sEvyEeTh5/H6NFu2akqoooP1cVKs44SqielsoSOZYSxM/pzvNHT2aO69bL7pcCGayNvlbzXFaQupBwGzh/6k4ihuS4W+Y0D2rXyHSdTrjHhyuAD0iPm+bmoZvSYd2amUrMNQAvO8EB1ua4Yp8NgiXg/zDucdBOoGO0xtQxxd6na89fADEUhC+QmbRzgGjIakLhBzQ7eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T6GEQk9YJsATplAUZEKMH2KYN8lWSqiwfLzK5V3TfJY=; b=M/U01/NGe83Lh8AAoe3GJxkxqekgkb/0dEU78Af8V3yeYFKkbhCyXQj3B6OJC4yphQ1wIx+1dzLBODAqR2VUpZM0SM/9pDQVW2CKA6nZyUfNN/j7y5m+hGisMT0ZeYbGBnowxpqe/zYYkVPl4ne4IIx3TofAOt70ezMnbyAgHlZQGjE0guBtR4aA2/aSLnuxemcjGNOLBOICL/p1c88TelCryfQsHRmx4+jiEX4aIB9oNF6k3a1+IrB41ZNAjCBu/71qhyv//G4GdODDNw6pVEMG8UzydEIncek3ZCvPhblJnzW7OSXKa2JQSZb96wKZ3Ceyh271440BhEmpRl3xIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T6GEQk9YJsATplAUZEKMH2KYN8lWSqiwfLzK5V3TfJY=; b=WnAIAnZDYdpOksep34zt4pasmb78afRddKWPAUxAJavcCtx1CeKUTODwEUiNTxRC4lenSnva9/EaVqVS7mgaiiXqh9Hhur5kwe2AvB+h1ThtdMj9ON69cqntw6Cw3RWuY9W7cizCEC8vmB8nWAUPfjOQcimN0bnS6npd0MgnZR0= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from PR3PR08MB5852.eurprd08.prod.outlook.com (2603:10a6:102:8e::21) by AS2PR08MB9668.eurprd08.prod.outlook.com (2603:10a6:20b:604::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.28; Thu, 26 Jun 2025 16:03:19 +0000 Received: from PR3PR08MB5852.eurprd08.prod.outlook.com ([fe80::f44:d113:1c29:825d]) by PR3PR08MB5852.eurprd08.prod.outlook.com ([fe80::f44:d113:1c29:825d%6]) with mapi id 15.20.8857.026; Thu, 26 Jun 2025 16:03:19 +0000 Message-ID: <60394d33-98e9-444e-98e9-fb30d60f399f@arm.com> Date: Thu, 26 Jun 2025 17:03:18 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 04/11] gdb, gdbserver: Use xstate_bv for target description creation on x86. To: "Schimpe, Christina" , "gdb-patches@sourceware.org" Cc: "thiago.bauermann@linaro.org" , "eliz@gnu.org" References: <20250617121147.1956686-1-christina.schimpe@intel.com> <20250617121147.1956686-5-christina.schimpe@intel.com> <4c57870a-7233-49b6-990c-9e6f3b7ce452@arm.com> Content-Language: en-US From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0430.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18b::21) To PR3PR08MB5852.eurprd08.prod.outlook.com (2603:10a6:102:8e::21) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PR3PR08MB5852:EE_|AS2PR08MB9668:EE_|DB1PEPF000509F3:EE_|GV2PR08MB8171:EE_ X-MS-Office365-Filtering-Correlation-Id: 4dd17c6f-5db6-4d90-99c7-08ddb4cb0cb7 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|1800799024|366016|376014|7053199007; X-Microsoft-Antispam-Message-Info-Original: =?utf-8?B?SHc2WGs2UGxpMFIvQVZ5cW9hNnRSRy9MVEJ0SVhQa3VxcXNTamduNjVycXJ3?= =?utf-8?B?aHh4VGRzVWRTL3lTZUxvajcrVzUxcDBGL2VYQ1poUCtyL3Z1TnZ5REVabUNQ?= =?utf-8?B?eU5SWnEyOEVxMUhWZmdxN3AzeFVhbEkrTTAvRVlTTnRxemNNWlZrL2RqNjlq?= =?utf-8?B?Y1NyYlVrYzBjWnJYalpsblNUbFBFZ1E0elBwazgvc1RZY2JxRmF4TEx6ZS8z?= =?utf-8?B?ZW8rbkhFU1hyQ2NDQjBFZHJvcC96UVplczFMZUtpazZrdVBmMUlJeXlYbG85?= =?utf-8?B?OFFDMVhWSnlqSUJxZEY4V2w5MGhPSGk1eXJpYm9tNVVIM1NyN0tuM2I4TDl5?= =?utf-8?B?VTZWK2h1eWUwRnloUFhlcUdGdkdHOTY0V1FYNGJpK0ZoaUU0eEtlWGNRV2FL?= =?utf-8?B?S2d5NkJVMWV2ZER1cDhMZ095SWMvNTJVRmYzNXFTSnZWSnRlR0xoK1NIaW54?= =?utf-8?B?NkNObHJYZ2lRcXFwYk1jRFNNWnpwR3FiZzY4TTlGQkUzMkVhWFNJY3pLSy9L?= =?utf-8?B?VEQrc1VNSUdGbENCUEFPN0VWbzYydDhoRWZuVDBuWFUrTVJDZm9WWVFTcmV5?= =?utf-8?B?RVNGU0Y5Nkc1cTJEeGdWVGdUUTlvRVVBL0V5NTEzaGU1VEJHVUdpYkNGVG9X?= =?utf-8?B?cnJTSEVLQzg2MFRVQWozSnRlNWRQL2xlc05HK1dpaGVJTXllL3UwSlV4d3Nk?= =?utf-8?B?VzFkV0xuTGdzVDRIZzF5UCtrK1l5TW5STG45TDJlWktqMnpwektIaVBMcmRm?= =?utf-8?B?Q1NFYXNQdzhNUEMrSm5rc0UvbUQ1WXRPaEJmQ3RxL2NkNXI1WVhlRnBDS3pC?= =?utf-8?B?bTJQN21LS2w3eWtFSms2K0JqOUtOeGVGOXQ3eUtlUmUvMHVOaHhOTWcyb0lv?= =?utf-8?B?ajhwNXNJVDU3dnpsS2Z4RDJ5bDFLMWlUZS9jWUt2c2o4dFhObllpbzJFMjNT?= =?utf-8?B?U2FmS08rcFZyTUJpbEpFMjlqNnA4RkFNbWIxcWtiZ2VZUVpPTmE3bk9RWnNV?= =?utf-8?B?RGNjQTM0MFljLzdXYmtRMnNmZS9qSDdoVVpNTUZhQ3Z6dURIY2d1VmtmLzdn?= =?utf-8?B?cUk0UmJQYmV4MWo2S1pXWkY5ZW9hYWVnOVdBODk5WWxNWFVKM2FQanMxNHFC?= =?utf-8?B?MTZOT1N4M0duWHdkUFRFWUJYdlh0bGF3dTFldTNJQ3BKNUlvTC9uVUx4a0py?= =?utf-8?B?bWFBT3V5bzROYUJZUnJsbmJKVm4xMXphRzRwS1BqNHh2YjgvY0tWeFAxTjhM?= =?utf-8?B?d3dFNERjN2ZzbmE0eG96dk03ZHFNKzVCK1NVVENDWUtwSWZpQzhHZHExZ0dS?= =?utf-8?B?bW5lUmlFZW14Q1hlYnkwMUJCdWtzd0QveUozSmE3MXR5bzBkajZXTXN2SXB6?= =?utf-8?B?RU9JZjQ1NFVXL3NDZ0ZTTUtDUDdzWWs2RHVVU0xaaHNLMDloandod3VweG5r?= =?utf-8?B?SjgxR01sMlFnMWhrb1lkT256OXJiQml3dUlCMndWaGZibjdkWVh6Z2p1WGNL?= =?utf-8?B?MmxXSGVvNWhzdWE3VWhmdmVmYjR3TXZveFFGci9aYTE0YkkzYnlxek1jZGh6?= =?utf-8?B?UlhoV0tjZHpVdHFTSjJQM3Mvc3hmZjVKaEUyNCtaZGYzRDVxYTg0Qy9Ycmpj?= =?utf-8?B?MTQvOGMwYlBIQzQvSHhQbjBIYTZWQ1pURTZQUU1VTFhXd0pGUVRwZjlIVmE1?= =?utf-8?B?NjlZb216dVV5WkFQTUJaUEF4ZlA3eWRxYWdJa2o5Q042NUhoQ3ZSZGVlZlVJ?= =?utf-8?B?YzVmYkJSRG92U0ZtWlJGZFhxSGJaNkM1U1ZwYWtBb0diSlJUR0NtdnU0QjJE?= =?utf-8?B?SjUwaDRrbThQMmRsa0l2QkdaMmxkR2UzVUdFbFRKOVVnVXhwaVB3ZS9pQTZt?= =?utf-8?B?SlM0Z2xnU2JiM2ptMGpTVmJGTkRVMWYxeC9Fd09weHlGYWxTb1oyUUxoM21N?= =?utf-8?Q?gS14hid3ec0=3D?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PR3PR08MB5852.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(7053199007); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9668 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB1PEPF000509F3.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0db60dac-0824-47a7-d254-08ddb4caf7d3 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|1800799024|14060799003|35042699022|36860700013|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?V09JZUY0djRPZE1nUk02Y2tZWWhndnZaRnh0dkZZUDB6T2dKbERHbzhOaEta?= =?utf-8?B?UldiZ3FEWm1aN050dGkxaG5EaUY3UC8vM3Qzc3AzK3hrc1puYTRSOVFzVk5y?= =?utf-8?B?QWk0aTBqQk8rQTdpMlRZQllVczBnVHpxT2RENEhTWE1EanYvRXRkK01meXlk?= =?utf-8?B?Ym1yUUhkdkswNWZkOVRyVzRkSVJRMndNYjlCRUNCV3VBYm9WTDBLTkxhN3dC?= =?utf-8?B?YWNxaFo0USt0Y2Q5eWxwMWVPZWQ3b1c0NlYxWElQU0pSeDdkSzhoNXBpQTYx?= =?utf-8?B?MThhM1ZSbVlSRGd4bFg5MXRpMzh5OXhYNkkzZSsxcTdBdG9BU1Y3SDc1Y2FS?= =?utf-8?B?ZDN3QjJjbXZRczNtRHBhbjU5b05HcW9MZVNYM3ZkeURQUnZsd29Da2V6NG5o?= =?utf-8?B?QVNaZ1JIandQaWhwSzhucUZVa0FpbU9ZRy9XRzVjRlNKZzh5eTJZazAwTWlv?= =?utf-8?B?ZnFaUWJ0VzRrZXRvaDI1TCtiUldaMkFSdkxUeDRWMXJlSVF3bGN4TndsbDhJ?= =?utf-8?B?cWI5dmpBendUdlBmVDVuSGdTWm9RaTh4QmdkbE1xZ0VPaCtjS2FpMW9ycmpU?= =?utf-8?B?YUl4YStwcTRIVXZKZlgvVEV1QlNteVk0ODh2U3IyM3RJekNmdHJNUFY0OGZF?= =?utf-8?B?WnJYS1lSOFdFaTYyN294SHQ4Mzg2WklueGFxWDhQMlliVmN5cXdUN285NUdt?= =?utf-8?B?VVI4ZlMxSmsrZWNIYlJ3UCtyQWRoOVBiVkJtNXlmd1dtTkEzVXpuaFVRajF6?= =?utf-8?B?VGtzMjNuZUErL1MzZUtaWGxqMXFiRmJVRm43TnYwUUw2OHRVc0hCUE5PSHgv?= =?utf-8?B?Q2xza2kvOElGVGVheFJPR2kzSVdmZXRzdDk0OG9FZ09aWXlQVXp5V0tSZjBH?= =?utf-8?B?K1l5cnBZWEEvWFdsU1RXMkhJVzlWMm80WDRSK2Z3K0RSRXduVDBMcUpGZ2V4?= =?utf-8?B?RTArMFpFS042bFYxVXFrN0txL3l6Z0VGSXNrcmFya1l5K1lYZkt0WmtROWlM?= =?utf-8?B?eXV3WVg3QWVTNG9qTjdTUUdLak1mSDdJZllWM1V0Zmx3ek1aM2NYandjamlU?= =?utf-8?B?TEhFSklnTlAyRGtuS1FKM1QvSlRJYXdUTm1GVys3NGQrNE5YTWFhaFM1eWRC?= =?utf-8?B?TklMdWdWOExSdWJ3KzZNVmpjSFN6TDNCalJ5Z2NLTzFkR2Q5Y2EzVUJjYUNm?= =?utf-8?B?QXQxZ295a2NDbGZGUVRzVnRzRUc4dnVzVkg4bG1rakMvRmg2cWFLK0NNQkdh?= =?utf-8?B?SFlldHNuWTE5bTBNRG14UTNHZ2NDUjhkRE5oMUllMlE0ak8wK3dORWg1dXRK?= =?utf-8?B?MUZibW5nMGZ6aHhEcUYzdDFtekpGUjVySmdPM3RPL3Nxa2JoTTBUVjNwV29I?= =?utf-8?B?eFo5aVpCMUFtUi9TRDFoNFVwelVCZFUrcGo4M2l5SlAvbUFWTGUxR2RnT21m?= =?utf-8?B?dXFUd2E1VWZzOWJuVXVPNnhPOWxCQ1AvTFp4d3QwM2VqWi9pbWs0NWZhdHlD?= =?utf-8?B?QVBQeDh0NzgwSGRBUEhvbG1EbmEzZGdqTm5tdVRqSStuV0lON1FSam0ydzA2?= =?utf-8?B?V2hHQmJHVEo4SWdQV1Bta1F2QXdpL3MrVHhpWlVwUEp3SURickM4L2x0UERN?= =?utf-8?B?aDJVZXEvb1dubzlINEJoQWlOajdOM3RuMFZPZUdWc1daQTJJQlRnenBqN3E5?= =?utf-8?B?YmZYQVBZUmhvZld2M3pSdzlablFHOFVablZHdkN1SiszTkZpWE9aOHFWRlIy?= =?utf-8?B?UVhsTzJTR3lMcVRBUWIwS0RjYVJXZ2RSNTVtaUZJUFdDdXp1c2lnTUM2bExr?= =?utf-8?B?NFE4WElVYjFzRzA3eldqOENMaVRiQU5ldUVMd2VPKzRRYkI3NlplV0RETUQ2?= =?utf-8?B?SzJNOEg4bTRsR0hFWjUyOUNIQXR6aWdiTTFUVGlyS01LS0FBSi8ydE52a2VS?= =?utf-8?B?WVZ3VWQ5dlhBNlI4ekVNYkVpMU1wbWd0UU05OSs5Y2w4cDZkRkJGR0FkSGxU?= =?utf-8?B?ei9KQWJ5c3F2NlQ4aytCQm9ObUJzeVBzVi9aZTFuL1Y3aWE0eURQcXVSeUVt?= =?utf-8?Q?6TQ3pX?= X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(82310400026)(1800799024)(14060799003)(35042699022)(36860700013)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2025 16:03:54.0122 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4dd17c6f-5db6-4d90-99c7-08ddb4cb0cb7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509F3.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8171 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/24/25 14:46, Schimpe, Christina wrote: > Hi Luis, > >> -----Original Message----- >> From: Luis Machado >> Sent: Monday, June 23, 2025 2:56 PM >> To: Schimpe, Christina ; gdb- >> patches@sourceware.org >> Cc: thiago.bauermann@linaro.org; eliz@gnu.org >> Subject: Re: [PATCH v4 04/11] gdb, gdbserver: Use xstate_bv for target >> description creation on x86. >> >> On 6/23/25 13:46, Schimpe, Christina wrote: >>> Hi Luis, >>> >>> Thanks a lot for the feedback. Please find my comments below. >>> >>>> -----Original Message----- >>>> From: Luis Machado >>>> Sent: Thursday, June 19, 2025 11:24 AM >>>> To: Schimpe, Christina ; gdb- >>>> patches@sourceware.org >>>> Cc: thiago.bauermann@linaro.org; eliz@gnu.org >>>> Subject: Re: [PATCH v4 04/11] gdb, gdbserver: Use xstate_bv for >>>> target description creation on x86. >>>> >>>> On 6/17/25 13:11, Christina Schimpe wrote: >>>>> diff --git a/gdb/arch/amd64.c b/gdb/arch/amd64.c index >>>>> 252650b6390..9cac0645cdc 100644 >>>>> --- a/gdb/arch/amd64.c >>>>> +++ b/gdb/arch/amd64.c >>>>> @@ -30,14 +30,11 @@ >>>>> >>>>> #include "../features/i386/x32-core.c" >>>>> >>>>> -/* Create amd64 target descriptions according to XCR0. If IS_X32 is >>>>> - true, create the x32 ones. If IS_LINUX is true, create target >>>>> - descriptions for Linux. If SEGMENTS is true, then include >>>>> - the "org.gnu.gdb.i386.segments" feature registers. */ >>>>> +/* See amd64.h. */ >>>> >>>> More appropriate to reference arch/amd64.h. >>> >>> True, will fix. >>> >>>> >>>>> >>>>> target_desc * >>>>> -amd64_create_target_description (uint64_t xcr0, bool is_x32, bool >> is_linux, >>>>> - bool segments) >>>>> +amd64_create_target_description (uint64_t xstate_bv_mask, bool is_x32, >>>>> + bool is_linux, bool segments) >>>>> { >>>>> target_desc_up tdesc = allocate_target_description (); >>>>> >>>>> @@ -62,13 +59,13 @@ amd64_create_target_description (uint64_t xcr0, >>>> bool is_x32, bool is_linux, >>>>> if (segments) >>>>> regnum = create_feature_i386_64bit_segments (tdesc.get (), >>>>> regnum); >>>>> >>>>> - if (xcr0 & X86_XSTATE_AVX) >>>>> + if (xstate_bv_mask & X86_XSTATE_AVX) >>>>> regnum = create_feature_i386_64bit_avx (tdesc.get (), regnum); >>>>> >>>>> - if (xcr0 & X86_XSTATE_AVX512) >>>>> + if (xstate_bv_mask & X86_XSTATE_AVX512) >>>>> regnum = create_feature_i386_64bit_avx512 (tdesc.get (), >>>>> regnum); >>>>> >>>>> - if (xcr0 & X86_XSTATE_PKRU) >>>>> + if (xstate_bv_mask & X86_XSTATE_PKRU) >>>>> regnum = create_feature_i386_pkeys (tdesc.get (), regnum); >>>>> >>>>> return tdesc.release (); >>>> >>>> <...> >>>> >>>>> diff --git a/gdb/arch/i386.c b/gdb/arch/i386.c index >>>>> 835df53c75d..84f31439e7a 100644 >>>>> --- a/gdb/arch/i386.c >>>>> +++ b/gdb/arch/i386.c >>>>> @@ -29,10 +29,11 @@ >>>>> #include "../features/i386/32bit-segments.c" >>>>> #include "../features/i386/pkeys.c" >>>>> >>>>> -/* Create i386 target descriptions according to XCR0. */ >>>>> +/* See i386.h. */ >>>> >>>> arch/i386.h >>> >>> Will fix. >>> >>>> >>>>> >>>>> target_desc * >>>>> -i386_create_target_description (uint64_t xcr0, bool is_linux, bool >>>>> segments) >>>>> +i386_create_target_description (uint64_t xstate_bv_mask, bool is_linux, >>>>> + bool segments) >>>>> { >>>>> target_desc_up tdesc = allocate_target_description (); >>>>> >>>>> @@ -44,10 +45,10 @@ i386_create_target_description (uint64_t xcr0, >>>>> bool is_linux, bool segments) >>>>> >>>>> long regnum = 0; >>>>> >>>>> - if (xcr0 & X86_XSTATE_X87) >>>>> + if (xstate_bv_mask & X86_XSTATE_X87) >>>>> regnum = create_feature_i386_32bit_core (tdesc.get (), regnum); >>>>> >>>>> - if (xcr0 & X86_XSTATE_SSE) >>>>> + if (xstate_bv_mask & X86_XSTATE_SSE) >>>>> regnum = create_feature_i386_32bit_sse (tdesc.get (), regnum); >>>>> >>>>> if (is_linux) >>>>> @@ -56,13 +57,13 @@ i386_create_target_description (uint64_t xcr0, >>>>> bool >>>> is_linux, bool segments) >>>>> if (segments) >>>>> regnum = create_feature_i386_32bit_segments (tdesc.get (), >>>>> regnum); >>>>> >>>>> - if (xcr0 & X86_XSTATE_AVX) >>>>> + if (xstate_bv_mask & X86_XSTATE_AVX) >>>>> regnum = create_feature_i386_32bit_avx (tdesc.get (), regnum); >>>>> >>>>> - if (xcr0 & X86_XSTATE_AVX512) >>>>> + if (xstate_bv_mask & X86_XSTATE_AVX512) >>>>> regnum = create_feature_i386_32bit_avx512 (tdesc.get (), >>>>> regnum); >>>>> >>>>> - if (xcr0 & X86_XSTATE_PKRU) >>>>> + if (xstate_bv_mask & X86_XSTATE_PKRU) >>>>> regnum = create_feature_i386_pkeys (tdesc.get (), regnum); >>>>> >>>>> return tdesc.release (); >>>> >>>> <...> >>>> >>>>> diff --git a/gdb/x86-linux-nat.c b/gdb/x86-linux-nat.c index >>>>> fc7c5f642ed..a82ad21da27 100644 >>>>> --- a/gdb/x86-linux-nat.c >>>>> +++ b/gdb/x86-linux-nat.c >>>>> @@ -97,15 +97,20 @@ const struct target_desc * >>>>> x86_linux_nat_target::read_description () { >>>>> /* The x86_linux_tdesc_for_tid call only reads xcr0 the first time it is >>>>> - called, the xcr0 value is stored here and reused on subsequent calls. */ >>>>> - static uint64_t xcr0_storage; >>>>> + called. The mask is stored in XSTATE_BV_STORAGE and reused on >>>>> + subsequent calls. Note that GDB currently supports features for user >>>>> + state components only. However, once supervisor state components >> are >>>>> + supported in GDB XSTATE_BV_STORAGE will not be configured based >> on >>>>> + xcr0 only. */ >>>> >>>> Something about the comment above reads off in the last phrase. Is >>>> there a missing connection word? >>> >>> I agree, would this be a bit better? >>> >>> "However, once supervisor state components are supported in GDB, the >>> value XSTATE_BV_STORAGE will not be configured based on xcr0 only." >>> >> >> Yes, that reads better, thanks. >> >> I don't think you need a new iteration for these fixes though. They could be >> local. > > Just to be sure, you mean for this patch or your comments on the series in general? > I meant on this patch. Sorry, missed this reply.