From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44837 invoked by alias); 4 Oct 2016 17:33:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44824 invoked by uid 89); 4 Oct 2016 17:33:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=policy X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Oct 2016 17:33:47 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 98D374E4CD; Tue, 4 Oct 2016 17:33:46 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u94HXjSd027731; Tue, 4 Oct 2016 13:33:45 -0400 Subject: Re: [PATCH] Allow DW_OP_GNU_uninit in dwarf_expr_require_composition To: Andreas Arnez , gdb-patches@sourceware.org References: From: Pedro Alves Message-ID: <6037e019-8bc0-ce3f-2a8f-a4d804bca01b@redhat.com> Date: Tue, 04 Oct 2016 17:33:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00051.txt.bz2 On 04/27/2016 06:38 PM, Andreas Arnez wrote: > In DWARF expression handling, some operators are required to be either > at the end of an expression or followed by a composition operator. So > far only the operators DW_OP_reg0-31 were allowed to be followed by > DW_OP_GNU_uninit instead, and particularly DW_OP_regx was not, which is > obviously inconsistent. > > This patch allows DW_OP_GNU_uninit after all operators requiring a > composition, to simplify the code and make it more consistent. This > policy may be more permissive than necessary, but in the worst case just > leads to a DWARF location description resulting in an uninitialized > value instead of an error message. Fine with me. DW_OP_GNU_uninit is underspecified, anyway. > > gdb/ChangeLog: > > * dwarf2expr.c (dwarf_expr_require_composition): Allow > DW_OP_GNU_uninit. > (execute_stack_op): Use dwarf_expr_require_composition instead of > copying its logic. OK. Thanks, Pedro Alves