From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119946 invoked by alias); 2 Jul 2018 02:04:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119552 invoked by uid 89); 2 Jul 2018 02:04:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=lack, Hx-languages-length:1521 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Jul 2018 02:04:17 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 295921E529; Sun, 1 Jul 2018 22:04:16 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1530497056; bh=Rk+DDqYKyyXYStbqFGPOXRSQPC+FpYjyyD18/OvZ58E=; h=Subject:From:To:References:Date:In-Reply-To:From; b=ppjxrpluBQMQOHy4Wl0qvcL13wsNR1fnVAxnpnJT25pUhXoSvk+gfkPcEXPKQHNF5 26dBWCwTTQmRtFcrWND/ONEToZlAYQHOT6vDp4ZV7x4ICnTTWnYMECjLdQNZ/Weg/h vo3t4rz4yvkUCTRfUtmPJhPSnEyiHprlY2oXclRc= Subject: Re: [PATCH v4] Fix segfault when invoking -var-info-path-expression on a dynamic varobj From: Simon Marchi To: Jan Vrany , gdb-patches@sourceware.org References: <20180628205431.27844-1-jan.vrany@fit.cvut.cz> <57e1cd0c-c9bc-896f-16a7-daa89e916079@simark.ca> Message-ID: <60370429-7eca-0600-dc41-06b5a9365560@simark.ca> Date: Mon, 02 Jul 2018 02:04:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <57e1cd0c-c9bc-896f-16a7-daa89e916079@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00008.txt.bz2 On 2018-07-01 09:43 PM, Simon Marchi wrote: >> diff --git a/gdb/testsuite/gdb.python/py-mi-var-info-path-expression.py b/gdb/testsuite/gdb.python/py-mi-var-info-path-expression.py >> new file mode 100644 >> index 0000000000..34d016fb89 >> --- /dev/null >> +++ b/gdb/testsuite/gdb.python/py-mi-var-info-path-expression.py >> @@ -0,0 +1,57 @@ >> +# Copyright (C) 2008-2018 Free Software Foundation, Inc. >> + >> +# This program is free software; you can redistribute it and/or modify >> +# it under the terms of the GNU General Public License as published by >> +# the Free Software Foundation; either version 3 of the License, or >> +# (at your option) any later version. >> +# >> +# This program is distributed in the hope that it will be useful, >> +# but WITHOUT ANY WARRANTY; without even the implied warranty of >> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> +# GNU General Public License for more details. >> +# >> +# You should have received a copy of the GNU General Public License >> +# along with this program. If not, see . >> + >> +import sys >> +import gdb >> +import gdb.types >> + >> +# Folowing is for Python 3 compatibility... > > "Following" > > There's an extra \n at the end of py-mi-var-info-path-expression.exp, which git > complains about. Actually, it might be the lack of \n at the end of py-mi-var-info-path-expression.py, please check that too. Simon