Re: [PATCH v2] Fix first time you type UP or DOWN in TUI's command window (Re: [RFC 8.3 0/3] Some style fixes)

Eli Zaretskii
2019-03-19T06:09:07Z

> Cc: tromey@adacore.com, gdb-patches@sourceware.org
> From: Pedro Alves <palves@redhat.com>
> Date: Mon, 18 Mar 2019 20:24:28 +0000
>
> > Still, I'd welcome some comments in
> > the header which explain the semantics of non-positive values of these
> > members, and for m_start_of_line, also its role in general. Fixing
> > this bug could have been much easier if that information was
> > available to begin with.
> For sure. This code predates me by a long shot. I wouldn't be
> surprised if it was already in the original TUI dump from HP.
>
> Anyway, I've stared at this for a while, and I _think_ this captures
> the idea. WDYT?

Thanks, LGTM. It certainly explains the values of these two members
and how they are used.

> + {
> + /* If we've reached the end of the line, so go back to
> + letting text output go to the console. */

A minor typo: "If ..., so ..." sounds weird. I think you wanted to
get rid of that "If".