From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15230 invoked by alias); 6 Apr 2017 14:32:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14169 invoked by uid 89); 6 Apr 2017 14:32:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Apr 2017 14:32:00 +0000 Received: by simark.ca (Postfix, from userid 33) id 13BFE1E80F; Thu, 6 Apr 2017 10:31:59 -0400 (EDT) To: Pedro Alves Subject: Re: [PATCH 2/2] Class-ify ptid_t X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 06 Apr 2017 14:32:00 -0000 From: Simon Marchi Cc: Simon Marchi , gdb-patches@sourceware.org In-Reply-To: <5c5e486c-54b1-31d7-887c-c3e92e667e6d@redhat.com> References: <20170404183235.10589-1-simon.marchi@ericsson.com> <20170404183235.10589-2-simon.marchi@ericsson.com> <580e9a8a-d59b-095c-cf56-ee2f50fe46df@redhat.com> <84b33a5c655af3f344494c9e9ee473d6@polymtl.ca> <03bc3933d454f9fa01567a0e1000e201@polymtl.ca> <5c5e486c-54b1-31d7-887c-c3e92e667e6d@redhat.com> Message-ID: <602b8c1244e73bbcb583bb29eb48f874@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.4 X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00143.txt.bz2 On 2017-04-06 07:12, Pedro Alves wrote: > Or leave it in ptid.c, doesn't have to be in a separate file. > Putting it in the .c file instead of the .h has the advantage > that it doesn't expose type_traits.h to all of gdb, that's all. > (Though I'm not sure whether be able to avoid it as we grow more > C++ utilities.) My intention was to put the tests in unittests/ptid-selftests.c, any objection to that?