Re: [PATCH] Add solib-aix5.c for AIX5 shared library support

[jtc@redback.com (J.T. Conklin)]

>>>>> "Kevin" == Kevin Buettner <kevinb@cygnus.com> writes:
Kevin> I am starting to merge the native port of GDB for AIX5/IA-64.  The
Kevin> patch below adds a new file solib-aix5.c to the gdb sources.  I have
Kevin> not tested this code yet on the traditional AIX architectures (Power,
Kevin> PPC), but it is my hope that it will be usable by those architectures
Kevin> as well.

I'm not qualified to comment on the meat of the patch, but it seems
like there are some svr4 bits that could be removed.  

For example, AIX 5 probably doesn't have the plethora of symbol names
found in all the svr4 varients (c.f. solib_break_names, bkpt_names). 
Also, in_svr4_dynsym_resolve_code() collides with a function of the
same name in solib-svr4.c (not that they'll be linked in the same GDB
now, but we shouldn't prelude the ability to do so in the future).
There is also a comment about FreeBSD stripping the dynamic linker,
which certainly sounds like it wouldn't be an issue on AIX.

For a new file, I'd also get rid of all the STREQ() calls and replace
them with the corresponding strcmp().

        --jtc

-- 
J.T. Conklin
RedBack Networks