From mboxrd@z Thu Jan 1 00:00:00 1970 From: jtc@redback.com (J.T. Conklin) To: Andrew Cagney Cc: GCC Patches , GDB Patches Subject: Re: [RFC] Move/Rename include/wait.h ("wait.h") Date: Thu, 09 Dec 1999 10:54:00 -0000 Message-id: <5mn1rk6j43.fsf@jtc.redbacknetworks.com> References: <384F481D.A77D2CEF@cygnus.com> X-SW-Source: 1999-q4/msg00359.html >>>>> "Andrew" == Andrew Cagney writes: Andrew> I'd like to put forward the proposal that the file Andrew> ``include/wait.h'' be either: Andrew> o renamed to include/gnu-wait.h (?) Andrew> o moved to gdb/gdb-wait.h If it's not used by other programs, I'd recommend that it be moved to gdb_wait.h (with an underscore, not a dash). I created gdb_string.h and gdb_stat.h long ago for the same sort of reasons. We might also want to consider creating a gdb_fcntl.h header to wrap fcntl.h. It would would define O_BINARY to 0 on hosts that don't distinguish between text and binary files; instead of having that definition scattered throughout various *.c files. --jtc -- J.T. Conklin RedBack Networks >From shebs@cygnus.com Thu Dec 09 12:15:00 1999 From: Stan Shebs To: jtc@redback.com Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.cygnus.com Subject: Re: [RFC] Move/Rename include/wait.h ("wait.h") Date: Thu, 09 Dec 1999 12:15:00 -0000 Message-id: <199912092015.MAA13565@andros.cygnus.com> References: <5mn1rk6j43.fsf@jtc.redbacknetworks.com> X-SW-Source: 1999-q4/msg00360.html Content-length: 1153 From: jtc@redback.com (J.T. Conklin) Date: 09 Dec 1999 10:53:48 -0800 >>>>> "Andrew" == Andrew Cagney writes: Andrew> I'd like to put forward the proposal that the file Andrew> ``include/wait.h'' be either: Andrew> o renamed to include/gnu-wait.h (?) Andrew> o moved to gdb/gdb-wait.h If it's not used by other programs, I'd recommend that it be moved to gdb_wait.h (with an underscore, not a dash). I created gdb_string.h and gdb_stat.h long ago for the same sort of reasons. I agree, this sounds like the right idea. We might also want to consider creating a gdb_fcntl.h header to wrap fcntl.h. It would would define O_BINARY to 0 on hosts that don't distinguish between text and binary files; instead of having that definition scattered throughout various *.c files. This would be good too, we have picked up a number of redundant definitions... Might be a good idea to consider doing the include of fcntl.h in defs.h, it's mentioned explicitly in nearly half the source files already, and the compiletime overhead of including it always would be pretty minor. Stan