From mboxrd@z Thu Jan 1 00:00:00 1970 From: jtc@redback.com (J.T. Conklin) To: RDBrown@mira.net Cc: RodneyBrown@mynd.com, gdb-patches@sources.redhat.com Subject: Re: PATCH: gdb/corefile.c (0401 snap on HP-UX). Date: Mon, 09 Apr 2001 10:24:00 -0000 Message-id: <5mhezy6l5z.fsf@jtc.redback.com> References: X-SW-Source: 2001-04/msg00094.html >>>>> "RDBrown" == RDBrown writes: RDBrown> gdb/corefile.c was failing to compile with a missing RDBrown> declaration for `symfile_objfile'. This allows gdb to build, RDBrown> but still hangs when starting the child process. Our discussions about removing unnecessary header files and a include file coventions didn't cover situations like this. While I expected some fallout from removing "unnecessary" headers, I thought they would occur because macroes defined in a target's tm-*.h or nm-*.h headers would require declarations from one of GDB's headers (like regcache.h, etc.). This is a bit different, because host specific behavior is in a common source file. I'm not sure that I like this patch, but I'm not sure I can come up with a resonable alternative in the short term. Perhaps the code to find the symbol file cooresponding to the core file (this is the bit that needs symfile_objfile) should be replaced with a config specific hook. But because it is also wrapped with HPUXHPPA, I'm not opposed to checking this in now, and fixing it up later. Would anyone else care to share their thoughts? If there are no objections, I'll get this patch committed soon. --jtc -- J.T. Conklin RedBack Networks