From: jtc@redback.com (J.T. Conklin)
To: gdb-patches@sourceware.cygnus.com
Subject: [RFC]: Move __CYGWIN__ hack to config/<arch>/xm-cygwin.h
Date: Thu, 01 Mar 2001 18:21:00 -0000 [thread overview]
Message-ID: <5m8zmooqqb.fsf@jtc.redback.com> (raw)
I found some code in defs.h that defines __CYGWIN__ if __CYGWIN32__ is
defined (if it is not already defined). While I admit that defs.h has
it's fair share of hacks they are more general (for the most part, they
add definitions missing from older UN*X systems (SEEK_SET, STDIN_FILENO,
etc.). IMO, this code belongs in a cygwin host header file.
The enclosed patch moves it from defs.h to config/i386/xm-cygwin.h and
config/powerpc/xm-cygwin.h. It seems to me there is enough duplication
in those two headers that a common config/xm-cygwin.h header is justified,
but I'll leave that to cygwin hackers to deal with.
Thoughts?
--jtc
2001-03-01 J.T. Conklin <jtc@redback.com>
* defs.h (__CYGWIN__): Moved conditional which defines __CYGWIN__
if __CYGWIN32__ is set from here.
* config/i386/xm-cygwin.h: To here.
* config/powerpc/xm-cygwin.h: To here.
Index: defs.h
===================================================================
RCS file: /cvs/src/src/gdb/defs.h,v
retrieving revision 1.38
diff -c -r1.38 defs.h
*** defs.h 2001/02/08 06:49:19 1.38
--- defs.h 2001/03/02 02:07:01
***************
*** 1259,1272 ****
#define MERGEPID(PID, TID) (PID)
#endif
- /* If under Cygwin, provide backwards compatibility with older
- Cygwin compilers that don't define the current cpp define. */
- #ifdef __CYGWIN32__
- #ifndef __CYGWIN__
- #define __CYGWIN__
- #endif
- #endif
-
/* Define well known filenos if the system does not define them. */
#ifndef STDIN_FILENO
#define STDIN_FILENO 0
--
J.T. Conklin
RedBack Networks
next reply other threads:[~2001-03-01 18:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-01 18:21 J.T. Conklin [this message]
2001-03-01 18:41 ` Christopher Faylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5m8zmooqqb.fsf@jtc.redback.com \
--to=jtc@redback.com \
--cc=gdb-patches@sourceware.cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox