From mboxrd@z Thu Jan 1 00:00:00 1970 From: jtc@redback.com (J.T. Conklin) To: Andrew Cagney Cc: gdb-patches@sourceware.cygnus.com Subject: Re: [RFA]: Remove unused header files. Date: Tue, 06 Mar 2001 13:08:00 -0000 Message-id: <5m4rx661xh.fsf@jtc.redback.com> References: <5mitltndwn.fsf@jtc.redback.com> <3A9FC8E8.F1B486C5@cygnus.com> <5mpufzlmg5.fsf@jtc.redback.com> <3AA2CBD7.477B337F@cygnus.com> X-SW-Source: 2001-03/msg00121.html >>>>> "Andrew" == Andrew Cagney writes: >> Yes and no. If I was linting GDB configured for the mn10200, it >> regcache.h would be considered necessary, but for other cases it >> would not. Since I'm not planning on linting every possible config >> before deciding whether a header is unnecessary, it's not up to the >> job. Andrew> I think we need to clarify one of the ground rules - should Andrew> "tm.h" et.al. files be sucking in the things they refer to and Andrew> (assuming that is agreed) should that be addressed before Andrew> include headers are eliminated from .c files. Andrew> If that isn't done, I've the (rational) fear that these Andrew> cleanups will start breaking an unreasonable number of Andrew> existing targets. Rational? Well I'm still cleaning up Andrew> fallout from regcache.h - I've ~50 tm.h files that should Andrew> include regcache.h. I think you know my position already. I think it is reasonable to require that tm-, nm-, and xm- headers to include any headers that contain definitions, declarations, etc. that are needed. As a result, this lifts the requirement that all modules must include all header files that any (of the zillion) tm-, nm-, or xm- header depends on. --jtc -- J.T. Conklin RedBack Networks