From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51570 invoked by alias); 3 Jan 2018 16:41:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51560 invoked by uid 89); 3 Jan 2018 16:41:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Jan 2018 16:41:17 +0000 Received: from ESESSHC013.ericsson.se (Unknown_Domain [153.88.183.57]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id C9.73.27591.BA70D4A5; Wed, 3 Jan 2018 17:41:15 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.57) with Microsoft SMTP Server (TLS) id 14.3.352.0; Wed, 3 Jan 2018 17:41:15 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.60.216] (192.75.88.130) by DBXPR07MB320.eurprd07.prod.outlook.com (2a01:111:e400:941d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.4; Wed, 3 Jan 2018 16:41:12 +0000 Subject: Re: [RFA] (Ada) Add gdb-mi support for stopping at start of exception handler. To: Xavier Roirand , CC: References: <1514977774-30677-1-git-send-email-roirand@adacore.com> From: Simon Marchi Message-ID: <5fc8d022-c0d4-3095-8e2f-b68aef579196@ericsson.com> Date: Wed, 03 Jan 2018 16:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1514977774-30677-1-git-send-email-roirand@adacore.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN4PR0601CA0008.namprd06.prod.outlook.com (2603:10b6:803:2f::18) To DBXPR07MB320.eurprd07.prod.outlook.com (2a01:111:e400:941d::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7383f613-5888-4c2b-4769-08d552c8cd9c X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060);SRVR:DBXPR07MB320; X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB320;3:x1C0zGaQGiEqd34QXCCR37d8cu1ccp+XElE4PwrnAyouzJFHpcQ7MiVyVMnWhK+Uavs6pYcoLc4ydVkr47JBqiG3Em3DSDsf+KfZ9PsnofGV7YEnM8Wb1NwUiM+HbpLXO5X5AttU7Ek9irioGgxlyIlNY0uBXRu/tRdTrTcRidKc2tP8n8eQXd6l889iubrY9T55K05YOinl9p7eA9utmyFjDaU1cX5lu7+37sCpFWLfZOXE5WOj1VpXm1v/tZ5Z;25:4kowdFIwyswIS9iDDctJjZy97zjJ4zaafe8sr7aEqCjwtMwVajDExcslIJ15DUQUJlKbEy5WuohBsQ9RiChVlsHqLW4rl+W7GMHegL2rEwZjJAk24YYzb7hVLur/u/hBQHMMJhKP1fbuxLX/eXYugjOTgU2y0f+X/E4PrnV7tsuVgfFOzVCjpBM7yba8Q278Jqjzm8YsZ22b5B0I2/uGkoMIl3Abtx0ItDOBZHnOmvdBE7lv7Lb80J/AZHoayic7S0JMHwAD5nyW1MznoQ6v1IlCy24vWbx285gwIqZP83s9qCXOUXRrtsetIW5X4fy2OO1H8hTkC5fJ+jOy/EhoSQ==;31:RgYQyeqlo5JbvtkYdSx74K0vjiKzpCm55PLtfZk4do5qCVlbpFmI17SiIKSYgum0twTEcSj8/SdOGN/6qiKMFMuNxX5czXIakVzzwFfZ+9bQPwNPGYnmiDZNrT7cWCtKD3BuDlRkCxar4rpf7+Z5C7817v90si7hbyp2XVl2Q2YYdyLAZONNbqhy/iJCBlhiJYhG2gHnHO4toLb/nXi0hygUAofgkXRiUXxFNH48a5M= X-MS-TrafficTypeDiagnostic: DBXPR07MB320: X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB320;20:zYmh8Zoms9zqicbpwjUcWQb+3GPhjMSKIQT6n4W3QgF+GKWjQwKCTTwPK6lvS8V/iHADs2VPgXFVIBrzHwU3CKOLaUXFsENV/iXjHVcA1PyqPTgibPm2DI354xRj15/msoLrRZpsBAJN6IFMBVyn46bxY9KLyBwHpEIEQ68c6RKyJZt0EvoL9LIIOFB2dcZ4pIZFxoQCaK15NtnK2daegP0sC95M4nPS/dZM0+BP+MYwcYvLPtR5vqg2nTM1O+LSBIKUsMlHpSEdn1UBayuo0LZvxWKIh3LimAnS8R9TeOAM/8TLfvFg3TFRI6F62AZzw1VXRB6g2Hmd22qHpQHhbTGWxOan9B1/v8YetBS++giIA7cjZtqIhUaCT7IECX06nw9jPnCPpZQJa/xoIoW9IPNh8oqW3lKbxVJrGFTcIxa+x2o35BilpAWTFDkZ4W1Zx0MDor71JXWMm4TAkc8DaLHPUodt+LrUffnriM+jQQuX0xTBZWpl7g7rgHd6/4aN;4:EarAlBKMGmXyDa/I1aRra3dMCZdpX2x0A5YekBH+dq7F47ajRdXCBv6PWrLoel6PciMTuCVa96etlqBFabUKMoOxY15lYLXtx2OKMYaOtM4iqEeQJVKETxPY6oVOiG4u1B3lG5i6BfDzbQkvf2nOzazPGBRwroxwtXWQJ9LDDaVWC6soKORkEts6h+7JQYN2qWrnllD5GBU3G5dQ4iranOM9Or0q6uVXLHUnWihUbEG7zAYpzlzt1iab4B4e6wtSerXL0mS1Xe6DIK4K2gZwZtFu+8Kf4NQEFBHLm0kHbR6nyQNBzmMyUH7wf8+NjEol X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(60795455431006); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(3002001)(3231023)(944501075)(10201501046)(93006095)(93001095)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011);SRVR:DBXPR07MB320;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DBXPR07MB320; X-Forefront-PRVS: 0541031FF6 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(366004)(396003)(39380400002)(346002)(39860400002)(376002)(377424004)(199004)(189003)(24454002)(105586002)(31686004)(106356001)(49976008)(65806001)(66066001)(2486003)(76176011)(31696002)(23676004)(59450400001)(36756003)(25786009)(4326008)(52146003)(52116002)(305945005)(53546011)(478600001)(386003)(58126008)(47776003)(6246003)(8936002)(65956001)(7736002)(16526018)(81166006)(64126003)(16576012)(68736007)(81156014)(97736004)(316002)(53936002)(230700001)(2950100002)(83506002)(65826007)(8676002)(50466002)(6486002)(6666003)(86362001)(2906002)(229853002)(5660300001)(3846002)(6116002)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:DBXPR07MB320;H:[142.133.60.216];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQlhQUjA3TUIzMjA7MjM6cEhUNDdhRklDRzFIYTEzOFArT1NKYWVZSG9i?= =?utf-8?B?bVdCblFoL3lvV3RmK2RaaDlPNENWU2FqNUkybGxJMWplNGNnUXZ6c013L0FS?= =?utf-8?B?UzN3RFVtNDZnc1B0elV2Lzg4czNjMitxZkd4ZnIwVnJLd2dpaW5vek5oOVJu?= =?utf-8?B?UWRBTWtQK2loUEExUUhEdmc4a1NGNXNKeXEyakF3NVpTYlBqR1V1MWkrQ0py?= =?utf-8?B?VHptOUViQ3RWVTdJNE5jVHBNU3lxK3RrOVFuR0NPbFEvRmRXU2QzRFpEaDBp?= =?utf-8?B?TGU2VU80TWdqaVVGWGg0Y3pjUXY4bTRxM01GeFpZT0ozZDFaYXhpdjBXVGU1?= =?utf-8?B?aDA3WWxoSHlsTVVvTTBpS0dTRW1BNEFDTHJJbTNzRjRPeDlCSTVxc1FhL0xX?= =?utf-8?B?WGQ4UjFXdnJzNlkrdmFvaFBoSjJ2dkFiQWdvQ3NBbThvVXB5czdja1VNckQ1?= =?utf-8?B?NkcvczVTR0tYNkdNdkZrRTNOdzJ4eWpWUDJyU2Z4T2ZVUzlTWVRpS1o0VldU?= =?utf-8?B?TllBQncrRzhsVDhvV1FiUjlTN1JsbFJZRXUxMXBXREtEZmd4d2xqWEFWMDll?= =?utf-8?B?eWpPWXZNSU8yY0EyVzN3TU82WDJNeXlHeHhGOFlIakdZNHl3bFprVlN1dGF5?= =?utf-8?B?UVFtL2pGajBpVURCeUFaOG0wVU8xQnZwVUx6a2xKT2RCd1d6VkhwRUdWV29p?= =?utf-8?B?YndPcFJiRzRRS3AvbDRqMlg2VmZhblNuWURPSEFZK2xMMmRlRkI4UGtwSDdy?= =?utf-8?B?RTFZbTlhWkplbUZyQlVTeUtKdEs0WlcvMi82UGpkSjZuMGpSNkxuMmNrdm9U?= =?utf-8?B?akFRVWpjMnJmZW5OakMyMnNuOE5rNStKT0pvWkc4T0tya0wrTEs3dzUrQUlM?= =?utf-8?B?STlrNFhLUlNHZUR1ZCt1dDJxK0ZQSE1SaGF5T3c0b3AvNllybCsrc2dYdHQ1?= =?utf-8?B?dnRNQ003bmwyZlMvanJTY3pKUlVtUm9FSVl4L3MzSEMza1VONHhuNVMvVzJq?= =?utf-8?B?UXlJSG9iOXhBM1ZkSmJnbUdHTFkyRHhFUW53cDRVaWx5bisyZVVDcGw1bGRy?= =?utf-8?B?VEpCZTNmZnFLQThWZ1c1bnE0b1F0OXcvTTdZQmhYckQvOEpua0FTWUIrRncy?= =?utf-8?B?bzdwVUxFSFdEZWhNaFlZSExBOTRSY0dTMDAxSWhSbFpKSGgrVXdOaFNsY2NJ?= =?utf-8?B?UE1aZEd4eVNiQnl1U0NtUk5PbWtBVnFDam43WWVtMys1WTBiaVNWMUdpdlNU?= =?utf-8?B?VDZjMW5wZjhhbUY0M1N6R0NpWTd3d2ZPQ0luaUUybVN4YWxFMHJSZS9PMFp5?= =?utf-8?B?cThEZWpld2I1ZW5TbmcrUUZ1QVJJQWRTNis0Vnp5Y0NPRkcvaHQ0cFE1YWhY?= =?utf-8?B?TG0reERMTlhXc0p3OTFQZlJRUTBsZWFwSFhlZVd4dGZCOFdwUmEyRUxuUjc2?= =?utf-8?B?M2VmUlBVVXYxT0pHSWpadDduOG43UGpBNlRtbXRiV3NaUmttMmJ2V2F5QWxq?= =?utf-8?B?Vm90ZGlGdG51OUxWL1FKMHo3NDFsYXZzVzlwdUQvMFVUZkZmd1lHZlBlbUww?= =?utf-8?B?WGg4K203dDUwVUFjVFc0UzFRUWFsb0N1YVlyMEd5dmF3UHdvcWFPZVpKbnBv?= =?utf-8?B?SWlBREp4SEROcmYyK0VzWTF4ZkEwcVFNZTVtUXcrUm9BdENpOUdubllndTlV?= =?utf-8?B?cGJ3Qk1OMVpqRXBkZFJYT1M5TmpnbTJYcGRrRmtrYU0zM0kzUm1heEozM29h?= =?utf-8?B?SVY1RkZQeVZSbWxuT2U4YTkyeFc4WStiT29DQ0VnNGZFeC9zNTZrMitaNzBO?= =?utf-8?B?U3hCSDFFUGVzTG9ac1FPZzZXWmhjTXlacS9Pb2ZKQkZtRytONHY3b2lXOVJO?= =?utf-8?Q?j4pO6wUrKCm6hg0C2JPWwk+XMg5ESDO?= X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB320;6:2A/rIdko1HAgguZzvHx8Up9rAhhM/k+JMw8zvViu5Kuptwgr3EwEaXMAKw1f8yPpNvf6omtPPDu7nBCguNwqZcQ+TnXkFuS+sqjVOHg8nDIcvdZkvGll+HbklRgW/IEjbkpL+IyXZd10ualm59DU4jzAhounwz+b1E/fJNZdXaqF2MLJ4Vs7RmOgT9MFYWgSc/W/6oFfeOeOWqUFN/Di1rhGdFE3WJ703z5uiPvkqYDdKEC05pgOE7CD/nK7n9TyhZBazOSc46np0xOB+xzaWkSGV94MOBKRZdup9Vxcg9Bgij9vhM51pRuU5i1LNFXchdyjkWMwy8DpVvtJa3WLj7Pv1V8ix3hSxZQZCWGzTBc=;5:nWmxru3EQFllQ/FdzCErfOd1CiMXOa9EmoJ4QHkHWuu/+bh0tpjqXSatux+g9LprHFTji1ERoS3Tg43K9rBk/Su3FapfsEbxmKopjRu7kBvgTO+JS41bupT0FbZyI/VLlq/03pnQTISr5o89miVrs9mUw65L8GN64Eva6xDtxtg=;24:iBaJcIMOrs7mQdTX6OE11tF/OqL6yAS2Mhx+JngnC2bNX20Eone5+MuByyEA7+Mr4SwzbcH8Ppa6xXaXioip0A3ZLCFzV+j3HvH9ou+ugg8=;7:x4YiqsaV6DUT2EPfie3pO9ww0ulKgzvLjHQz9hHxhfcuXpc5u05IYE555yymWveG99zmBVAQ4MgGy3LmDBq7Z7PZ5fuALeJXrCvr1jy24Bbp7yV+QqAL77JZepufkPTeZ3RigbfIA7sE0v8fBPVgPc5rwTiUfT506MqRZnrJkD/oBp2C/2R5/CzCr6cLOdfhIiBT7RxTAdkKtL6iK19bF4QcQSUpyFZQVMgJ880L4MpS31ma5W1+oef83MRaPyYn SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2018 16:41:12.9457 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7383f613-5888-4c2b-4769-08d552c8cd9c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR07MB320 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00032.txt.bz2 On 2018-01-03 06:09 AM, Xavier Roirand wrote: > + /* This command does not accept any argument. Make sure the user > + did not provide any. */ > + if (oind != argc) > + error (_("Invalid argument: %s"), argv[oind]); > + > + scoped_restore restore_breakpoint_reporting > + = setup_breakpoint_reporting (); > + /* create_ada_exception_catchpoint needs EXCEPTION_NAME and CONDITION > + to be xstrdup'ed, and will assume control of their lifetime. */ > + if (exception_name != NULL) > + exception_name = xstrdup (exception_name); > + if (condition != NULL) > + condition = xstrdup (condition); > + create_ada_exception_catchpoint (gdbarch, ex_kind, > + exception_name, condition, > + temp, enabled, 0); > +} create_ada_exception_catchpoint claims that it takes ownership of the condition string and will deallocate it, but I don't think that's true. It looks like a memory leak to me. Could you take a look? Converting it to use std::string or gdb::unique_xmalloc_ptr instead would probably be the way to go eventually. Simon