From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YPfjAH5E6GXOyToAWB0awg (envelope-from ) for ; Wed, 06 Mar 2024 05:25:02 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gNe0GVKi; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id F04F01E0D2; Wed, 6 Mar 2024 05:25:01 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DAE811E092 for ; Wed, 6 Mar 2024 05:24:59 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 58177385803E for ; Wed, 6 Mar 2024 10:24:59 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 375A438582B6 for ; Wed, 6 Mar 2024 10:24:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 375A438582B6 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 375A438582B6 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709720645; cv=none; b=cdsUPp8P6yJBOxC9EkM7ZDTRYvlwSyC+CxYbpBJjkC3k6VW+kXzz0W7fYIpG7LZQgMmlnS6PPbg/PnX0uqWtp/lAj9aIaNGeyGGC56bR24z73j9Eme0c1MAndx7UPpn/cbTrvlCM0jpnG2zaf1a6SA3aGTnHPbjEKbTQ11YQ8ro= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709720645; c=relaxed/simple; bh=fqLrD/J/ZvVXM/i89uLyZZgJxg9yTescFX3Ned9WkPQ=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=o8NLf9997uPM50c0ZqKqOo7fIKYXTt8I7gft+JMvpBXOQJUWp5UYpmabxehB8RFI5I7YBhknbmCBmjsQi+98rTSMQrmHK8LMe+R22khLkJjydMtBo6DfrsVUZYwWdv72LHQwFEqc7ugLhCcYRgEM0Slex+6/Y1vJXdpVDeYwKjU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709720640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5Chr9ZwDKPM07ZObPaDmwHBAVuTJ97EuTvABjrQkukw=; b=gNe0GVKiMVkcipFZ3/QAW14bhNKZY5gcwkVdd6dMFdgfu5+XWvxBbvpiZeTyi0CqT32KM/ igkCIY0k7mMt9KbAvWTepFb32XmQ+elFbVtRS93MzrRoXobxkin6Ytlw314iFwiqzlyI3w JkEosX5ZLnY633LYH9jZYmQQLtBjhG0= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-662-ADWfGCfRMvCymOXNLAYNuQ-1; Wed, 06 Mar 2024 05:23:59 -0500 X-MC-Unique: ADWfGCfRMvCymOXNLAYNuQ-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a35ef7abe08so463625066b.2 for ; Wed, 06 Mar 2024 02:23:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709720638; x=1710325438; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5Chr9ZwDKPM07ZObPaDmwHBAVuTJ97EuTvABjrQkukw=; b=SA6ihm+vReiKZFYxjXje+tbCzGRm2qbtFoC9Kc3YxpgNCRniGA5LevIht9hmZVVz5N kIMhn2Hs8fefn+fmnRna0wK5FJAcfUek3j5yiP7aTfE4XTfcvGWvHWuqbJVgMhFROXXI JgtTERGVeM40nE6uIu8RqZCYKkTzC2hEhLBK6QCChbHrvGY6bWkt6fyfd0F+iGyYIJU6 vyCwKC6mDuGAguYMQXbwC8TI8NstrFXAzBqv/WbS43TY9hMbDpsapYLTHGN0pVxRgQFD gLkMvmZNKXzOc19bjLzGyTmJ60Cvdclxrkpg6sgTnpYiN82bKO0u5xT/HMU1ZXASPDM9 o3Uw== X-Gm-Message-State: AOJu0YxbqwBt2pRk04RZBqkhNUbrGfFVMTNhM+G+iFFB1F5U1rloJ3GH +m6Nrv1bt3kHzb0S1JqqDrE6t/Td2buNLuaWh8C6Sgm48y82s81+5K3A4pKO79VklBABS+k7ZZ8 pYTvc4wnwslI182v0+wiSXnceZLstl7elRgp7qBZnrznbOnig7N31Pc1Yxi8yOb9ubi3X/YgWII RYph0Ht7AD5YpmCVdo6Wc0C1MHZT/ri/cVvE1oqgQX37A= X-Received: by 2002:a17:906:7d3:b0:a45:c027:372 with SMTP id m19-20020a17090607d300b00a45c0270372mr558427ejc.68.1709720637838; Wed, 06 Mar 2024 02:23:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IHAmIFwCcaY6epfFJJR0rVN3ENK53m65GRKxOTP7Y3XXzuexRtK+b1F6fgjKZ+Orm5mPK9Jfw== X-Received: by 2002:a17:906:7d3:b0:a45:c027:372 with SMTP id m19-20020a17090607d300b00a45c0270372mr558409ejc.68.1709720637340; Wed, 06 Mar 2024 02:23:57 -0800 (PST) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id z20-20020a170906271400b00a441cb52bfcsm7018887ejc.165.2024.03.06.02.23.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 02:23:55 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv2 4/7] gdb: remove some dead code from completer.c Date: Wed, 6 Mar 2024 10:23:36 +0000 Message-Id: <5fade1ecaf0945d1f3fc3ecd58255c68a874c934.1709720449.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org In completer.c there is some code that is surrounded with '#if 0', this code: #if 0 /* There is no way to do this just long enough to affect quote inserting without also affecting the next completion. This should be fixed in readline. FIXME. */ /* Ensure that readline does the right thing with respect to inserting quotes. */ rl_completer_word_break_characters = ""; #endif This code, in some form, and always defined out, has been around since the original import of GDB. Though the comment hints at what the problem might be, it's not really clear what the issue is. And completion within GDB has moved on a long way since this code was written ... but not used. I'm proposing that we just remove this code. If/when a problem comes up then we can look at how to solve it. Maybe this code would be the answer ... but also, I suspect, given all the changes ... maybe not. I'm not sure carrying around this code for another 20+ years adds much value. There should be no user visible changes after this commit. --- gdb/completer.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/gdb/completer.c b/gdb/completer.c index cefac605a33..330c39598c5 100644 --- a/gdb/completer.c +++ b/gdb/completer.c @@ -241,14 +241,6 @@ filename_completer (struct cmd_list_element *ignore, tracker.add_completion (make_completion_match_str (std::move (p_rl), text, word)); } -#if 0 - /* There is no way to do this just long enough to affect quote - inserting without also affecting the next completion. This - should be fixed in readline. FIXME. */ - /* Ensure that readline does the right thing - with respect to inserting quotes. */ - rl_completer_word_break_characters = ""; -#endif } /* The corresponding completer_handle_brkchars -- 2.25.4